Add support for qemu-xen runnning in a Linux-based stubdomain
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest19 patches 11 repliesIn review
- v618 patches 9 repliesSuperseded
- v521 patches 33 repliesSuperseded
Changes in v7 from the cover letter
- Have libxl__write_stub_dmargs handle both minios and linux qemu arguments.
- Add Acked-by from Ian Jackson where approriate.
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | Document ioemu MiniOS stubdomain protocoldocs/ | +53 | 0 replies | |
| 2/19 | Document ioemu Linux stubdomain protocoldocs/ | +52 | 0 replies | |
| 3/19 | libxl: fix qemu-trad cmdline for no sdl/vnc casetools/ | +6 | 0 replies | |
| 4/19 | libxl: Allow running qemu-xen in stubdomaintools/ tools/ | +17 | 0 replies | |
| 5/19 | libxl: Handle Linux stubdomain specific QEMU options.tools/ tools/ tools/ +2 more | +186 | 0 replies | |
| 6/19 | libxl: Use libxl__xs_* in libxl__write_stub_dmargstools/ | +38 | 1 reply | |
| 7/19 | libxl: write qemu arguments into separate xenstore keystools/ | +49 | 3 replies | |
| 8/19 | xl: add stubdomain related options to xl config parserdocs/ tools/ | +30 | 0 replies | |
| 9/19 | tools/libvchan: notify server when client is connectedtools/ | +3 | 0 replies | |
| 10/19 | libxl: add save/restore support for qemu-xen in stubdomaintools/ tools/ | +38 | 0 replies | |
| 11/19 | tools: add missing libxenvchan cflagstools/ | +1 | 0 replies | |
| 12/19 | tools: add simple vchan-socket-proxy.gitignore tools/ tools/ | +486 | 2 replies | |
| 13/19 | libxl: Refactor kill_device_model to libxl__kill_xs_pathtools/ tools/ tools/ | +36 | 0 replies | |
| 14/19 | libxl: use vchan for QMP access with Linux stubdomainconfigure docs/ stubdom/ +6 more | +209 | 0 replies | |
| 15/19 | libxl: require qemu in dom0 for multiple stubdomain consolestools/ | +10 | 0 replies | |
| 16/19 | libxl: ignore emulated IDE disks beyond the first 4tools/ | +11 | 0 replies | |
| 17/19 | libxl: consider also qemu in stubdomain in libxl__dm_active checktools/ | +8 | 0 replies | |
| 18/19 | docs: Add device-model-domid to xenstore-pathsdocs/ | +5 | 0 replies | |
| 19/19 | libxl: Check stubdomain kernel & ramdisk presencetools/ | +16 | 0 replies |
Reviews trailers per patch
All 19 patches have a Reviewed-by or Acked-by.
| Patch | Ian Jackson | Jason Andryuk | Wei Liu |
|---|---|---|---|
| 1/19 | A-b | ||
| 2/19 | A-b | ||
| 3/19 | A-b | R-b | A-b |
| 4/19 | A-b | ||
| 5/19 | A-b | ||
| 6/19 | A-b | ||
| 7/19 | A-b | R-b | |
| 8/19 | A-b | R-b | |
| 9/19 | A-b | ||
| 10/19 | A-b | ||
| 11/19 | A-b | R-b | |
| 12/19 | A-b | R-b | |
| 13/19 | A-b | ||
| 14/19 | A-b | ||
| 15/19 | A-b | ||
| 16/19 | A-b | R-b | |
| 17/19 | A-b | R-b | |
| 18/19 | A-b | ||
| 19/19 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v7 00/19] Add support for qemu-xen runnning in a Linux-based stubdomain
Hi,
Below is mostly the v6 cover leter with a few additions. All patches are Acked except for
libxl: Use libxl__xs_* in libxl__write_stub_dmargs
libxl: write qemu arguments into separate xenstore keys
These are refactored into Ian's preferred form (I think). A single loop for the xenstore transaction with behaviour differing for MiniOS and Linux stubdoms.
In coordination with Marek, I'm making a submission of his patches for Linux stubdomain device-model support. I made a few of my own additions, but Marek did the heavy lifting. Thank you, Marek.
General idea is to allow freely set device_model_version and device_model_stubdomain_override and choose the right options based on this choice. Also, allow to specific path to stubdomain kernel/ramdisk, for greater flexibility.
First two patches add documentation about expected toolstack-stubdomain-qemu interface, both for MiniOS stubdomain and Linux stubdomain.
Initial version has no QMP support - in initial patches it is completely disabled, which means no suspend/restore and no PCI passthrough.
Later patches add QMP over libvchan connection support. The actual connection is made in a separate process. As discussed on Xen Summit 2019, this allows to apply some basic checks and/or filtering (not part of this series), to limit libxl exposure for potentially malicious stubdomain.
Jason's additions ensure the qmp-proxy (vchan-socket-proxy) processes and sockets are cleaned up and add some documentation.
The actual stubdomain implementation is here:
https://github.com/jandryuk/qubes-vmm-xen-stubdom-linux
(branch initramfs-tools, tag for-upstream-v6)
See readme there for build instructions. Marek's version requires dracut. I have hacked up a version usable with initramfs-tools.
The v6 version is needed to be compatible with these changes in the v6 posting:
- Mini-OS stubdoms use dmargs xenstore key as a string. Linux stubdoms use dm-argv as a directory for numbered entries.
- The hardcoded "fd:3" for the restore image is replaced with the placehodler string $STUBDOM_RESTORE_INCOMING_ARG. The stubdom initscript needs to replace that with a an "fd:$FD" string to the hooked up console 2.
Few comments/questions about the stubdomain code:
1. There are extra patches for qemu that are necessary to run it in stubdomain. While it is desirable to upstream them, I think it can be done after merging libxl part. Stubdomain's qemu build will in most cases be separate anyway, to limit qemu's dependencies (so the stubdomain size).
2. By default Linux hvc-xen console frontend is unreliable for data transfer (qemu state save/restore) - it drops data sent faster than client is reading it. To fix it, console device needs to be switched into raw mode (stty raw /dev/hvc1). Especially for restoring qemu state it is tricky, as it would need to be done before opening the device, but stty (obviously) needs to open the device first. To solve this problem, for now the repository contains kernel patch which changes the default for all hvc consoles. Again, this isn't practical problem, as the kernel for stubdomain is built separately. But it would be nice to have something working with vanilla kernel. I see those options:
- convert it to kernel cmdline parameter (hvc_console_raw=1 ?)
- use channels instead of consoles (and on the kernel side change the default to "raw" only for channels); while in theory better design, libxl part will be more complex, as channels can be connected to sockets but not files, so libxl would need to read/write to it exactly when qemu write/read the data, not before/after as it is done now
Remaining parts for eliminating dom0's instance of qemu:
- do not force QDISK backend for CDROM
- multiple consoles support in xenconsoled
Changes in v2:
- apply review comments by Jason Andryuk
Changes in v3:
- rework qemu arguments handling (separate xenstore keys, instead of \x1b separator)
- add QMP over libvchan, instead of console
- add protocol documentation
- a lot of minor changes, see individual patches for full changes list
- split xenconsoled patches into separate series
Changes in v4:
- extract vchan connection into a separate process
- rebase on master
- various fixes
Changes in v5:
- Marek: apply review comments from Jason Andryuk
- Jason: Clean up qmp-proxy processes and sockets
Changes in v6:
- Squash vchan-proxy kill and socket cleanup into "libxl: use vchan for QMP access with Linux stubdomain".
- Use dm-argv as the xenstore directory for the QEMU arguments.
- Use $STUBDOM_RESTORE_INCOMING_ARG as a placeholder instead of hardcoding "fd:3".
- Comment to re-run autotools.
- Add Acked-by from Ian Jackson where approriate.
Changes in v7:
- Have libxl__write_stub_dmargs handle both minios and linux qemu arguments.
- Add Acked-by from Ian Jackson where approriate.
Eric Shelton (1):
libxl: Handle Linux stubdomain specific QEMU options.
Jason Andryuk (4):
libxl: Use libxl__xs_* in libxl__write_stub_dmargs
libxl: Refactor kill_device_model to libxl__kill_xs_path
docs: Add device-model-domid to xenstore-paths
libxl: Check stubdomain kernel & ramdisk presence
Marek Marczykowski-Górecki (14):
Document ioemu MiniOS stubdomain protocol
Document ioemu Linux stubdomain protocol
libxl: fix qemu-trad cmdline for no sdl/vnc case
libxl: Allow running qemu-xen in stubdomain
libxl: write qemu arguments into separate xenstore keys
xl: add stubdomain related options to xl config parser tools/libvchan: notify server when client is connected
libxl: add save/restore support for qemu-xen in stubdomain
tools: add missing libxenvchan cflags
tools: add simple vchan-socket-proxy
libxl: use vchan for QMP access with Linux stubdomain
libxl: require qemu in dom0 for multiple stubdomain consoles
libxl: ignore emulated IDE disks beyond the first 4
libxl: consider also qemu in stubdomain in libxl__dm_active check
.gitignore | 1 + configure | 14 +- docs/configure | 14 +- docs/man/xl.cfg.5.pod.in | 27 +- docs/misc/stubdom.txt | 105 ++++++ docs/misc/xenstore-paths.pandoc | 5 + stubdom/configure | 14 +- tools/Rules.mk | 2 +- tools/config.h.in | 3 + tools/configure | 46 ++- tools/configure.ac | 9 + tools/libvchan/Makefile | 8 +- tools/libvchan/init.c | 3 + tools/libvchan/vchan-socket-proxy.c | 478 ++++++++++++++++++++++++ tools/libxl/libxl_aoutils.c | 32 ++ tools/libxl/libxl_create.c | 46 ++- tools/libxl/libxl_dm.c | 558 +++++++++++++++++++++------- tools/libxl/libxl_domain.c | 10 + tools/libxl/libxl_internal.h | 22 ++ tools/libxl/libxl_mem.c | 6 +- tools/libxl/libxl_qmp.c | 27 +- tools/libxl/libxl_types.idl | 3 + tools/xl/xl_parse.c | 7 + 23 files changed, 1230 insertions(+), 210 deletions(-) create mode 100644 tools/libvchan/vchan-socket-proxy.c
Signature · 1 line
2.25.1