Skip to content

net: reduce dynamic lockdep keys

Cong Wang netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 8 repliesIn review
  2. v12 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: partially revert dynamic lockdep key changesdrivers/net/bonding/bond_main.c drivers/net/ethernet/netronome/nfp/nfp_net_repr.c drivers/net/hamradio/bpqether.c +19 more+294 -337 replies
2/2bonding: remove useless stats_lock_keydrivers/net/bonding/bond_main.c include/net/bonding.h+0 -40 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

Patch[email protected]Taehee Yoo
1/2Reported-and-tested-by A-b
2/2Reported-and-tested-by A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Patch net-next v2 0/2] net: reduce dynamic lockdep keys

syzbot has been complaining about low MAX_LOCKDEP_KEYS for a long time, it is mostly because we register 4 dynamic keys per network device.

This patchset reduces the number of dynamic lockdep keys from 4 to 1 per netdev, by reverting to the previous static keys, except for addr_list_lock which still has to be dynamic. The second patch removes a bonding-specific key by the way.

Cong Wang (2):
net: partially revert dynamic lockdep key changes
bonding: remove useless stats_lock_key

---
 drivers/net/bonding/bond_main.c               |  4 +-
 .../net/ethernet/netronome/nfp/nfp_net_repr.c | 16 ++++
 drivers/net/hamradio/bpqether.c               | 20 +++++
 drivers/net/hyperv/netvsc_drv.c               |  2 +
 drivers/net/ipvlan/ipvlan_main.c              |  2 +
 drivers/net/macsec.c                          |  2 +
 drivers/net/macvlan.c                         |  2 +
 drivers/net/ppp/ppp_generic.c                 |  2 +
 drivers/net/team/team.c                       |  1 +
 drivers/net/vrf.c                             |  1 +
 .../net/wireless/intersil/hostap/hostap_hw.c  | 22 +++++
 include/linux/netdevice.h                     | 27 ++++--
 include/net/bonding.h                         |  1 -
 net/8021q/vlan_dev.c                          | 23 +++++
 net/batman-adv/soft-interface.c               | 30 +++++++
 net/bluetooth/6lowpan.c                       |  8 ++
 net/core/dev.c                                | 90 +++++++++++++++----
 net/dsa/slave.c                               | 12 +++
 net/ieee802154/6lowpan/core.c                 |  8 ++
 net/l2tp/l2tp_eth.c                           |  1 +
 net/netrom/af_netrom.c                        | 21 +++++
 net/rose/af_rose.c                            | 21 +++++
 net/sched/sch_generic.c                       | 17 ++--
 23 files changed, 296 insertions(+), 37 deletions(-)
Signature · 1 line
2.26.1