credential-store: prevent fatal errors
Get series with b4
b4 am [email protected]Versions newest first
- v4 Latest4 patches 7 repliesIn review
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | credential-store: document the file format a bit moreDocumentation/ | +4 | 3 replies | |
| 2/4 | git-credential-store: skip empty lines and comments from storet/ | +15 | 2 replies | |
| 3/4 | git-credential-store: fix (WIP)credential-store.c t/ | +3 | 2 replies | |
| 4/4 | credential-store: make sure there is no regression with missing schemet/ | +17 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by.
| Patch | Eric Sunshine | Carlo Marcelo Arenas Belon | Jonathan Nieder | Junio C Hamano |
|---|---|---|---|---|
| Series | Helped-by Helped-by Helped-by Helped-by Helped-by Helped-by Helped-by Helped-by Helped-by | Based-on-patch-by Based-on-patch-by Based-on-patch-by Based-on-patch-by Based-on-patch-by Based-on-patch-by Based-on-patch-by Based-on-patch-by Based-on-patch-by | Helped-by Helped-by Helped-by | |
| 1/4 | ||||
| 2/4 | Helped-by | |||
| 3/4 | Helped-by | |||
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v4 0/4] credential-store: prevent fatal errors
with the added checks for invalid URLs in credentials, any locally modified store files which might have empty lines or even comments were reported[1] as failing to parse as valid credentials.
document better the format for the credential file and make sure any failures are still handled gently by the new code as a first step to allow people to upgrade without having first to fix their corrupted credential files.
[1] https://stackoverflow.com/a/61420852/5005936
Carlo Marcelo Arenas Belón (2):
git-credential-store: skip empty lines and comments from store
credential-store: make sure there is no regression with missing scheme
Jonathan Nieder (1):
git-credential-store: fix (WIP)
Junio C Hamano (1):
credential-store: document the file format a bit more
Documentation/git-credential-store.txt | 4 ++++ credential-store.c | 4 ++-- t/t0302-credential-store.sh | 32 ++++++++++++++++++++++++++ 3 files changed, 38 insertions(+), 2 deletions(-)
Signature · 1 line
2.26.2.569.g1d74ac4d14