Skip to content

scsi: ufs: support LU Dedicated buffer mode for WriteBooster

Stanley Chu linux-arm-kernel linux-mediatek linux-scsi lkml 8 versions – Applied

Status from this message: Applied to 5.8/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest8 patches 3 repliesApplied
  2. v78 patches 4 repliesSuperseded
  3. v68 patches 1 replySuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v58 patches11 repliesSuperseded
v48 patches2 repliesSuperseded
v35 patches7 repliesSuperseded
v25 patches6 repliesSuperseded
v14 patches5 repliesSuperseded

Changes in v8 from the cover letter

- In exported funtion ufshcd_fixup_dev_quirks(), add null checking for parameter "fixups" (Avri Altman)

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/8scsi: ufs: enable WriteBooster on some pre-3.1 UFS devicesdrivers/scsi/ufs/ufs_quirks.h drivers/scsi/ufs/ufshcd.c+49 -250 replies
2/8scsi: ufs: introduce fixup_dev_quirks vopsdrivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+18 -20 replies
3/8scsi: ufs: export ufs_fixup_device_setup() functiondrivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+8 -30 replies
4/8scsi: ufs-mediatek: add fixup_dev_quirks vopsdrivers/scsi/ufs/ufs-mediatek.c+19 -30 replies
5/8scsi: ufs: add "index" in parameter list of ufshcd_query_flag()drivers/scsi/ufs/ufs-sysfs.c drivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+17 -150 replies
6/8scsi: ufs: add LU Dedicated buffer mode support for WriteBoosterdrivers/scsi/ufs/ufs-sysfs.c drivers/scsi/ufs/ufs.h drivers/scsi/ufs/ufshcd.c +1 more+66 -120 replies
7/8scsi: ufs-mediatek: enable WriteBooster capabilitydrivers/scsi/ufs/ufs-mediatek.c+3 -00 replies
8/8scsi: ufs: cleanup WriteBooster featuredrivers/scsi/ufs/ufshcd.c+7 -131 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchAvri AltmanBean HuoCan GuoAsutosh Das
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b R-b R-b
6/8R-b R-b
7/8R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/8] scsi: ufs: support LU Dedicated buffer mode for WriteBooster

Hi,
This patchset adds LU dedicated buffer mode support for WriteBooster. In the meanwhile, enable WriteBooster capability on MediaTek UFS platforms.

v7 -> v8:
- In exported funtion ufshcd_fixup_dev_quirks(), add null checking for parameter "fixups" (Avri Altman)

v6 -> v7:
- Add device descriptor length check in ufshcd_wb_probe() back to prevent out-of-boundary access in ufshcd_wb_probe()
- Fix the check of device descriptor length (Avri Altman)
- Provide a new ufs_fixup_device_setup() function to pack both device fixup methods by general quirk table and vendor-specific way (Avri Altman)

v5 -> v6:
- Remove device descriptor length check in ufshcd_wb_probe()

v4 -> v5:
- Check LUN ID for available WriteBooster buffer only from 0 to 7 according to spec (Avri Altman)
- Skip checking any possible errors from ufshcd_read_unit_desc_param(hba, lun, UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS) in ufshcd_wb_probe() and check returned d_lu_wb_buf_alloc (shall be zero if error happens) (Avri Altman)

v3 -> v4:
- Introduce "fixup_dev_quirks" vops to allow vendors to fix and modify device quirks, and provide an initial vendor-specific device quirk table on MediaTek UFS platforms
- Avoid relying on common device quirk table for pre-3.1 UFS device with non-standard WriteBooster support (Can Guo)
- Fix comments for ufshcd_wb_probe() (Can Guo)
- Make ufshcd_wb_get_flag_index() inline and fix ufshcd_is_wb_flags() (Avri Altman)

v2 -> v3:
- Introduce a device quirk to support WriteBooster in pre-3.1 UFS devices (Avri Altman)
- Fix WriteBooster related sysfs nodes. Now all WriteBooster related sysfs nodes are specifically mapped to the LUN with WriteBooster enabled in LU Dedicated buffer mode (Avri Altman)

v1 -> v2:
- Change the definition name of WriteBooster buffer mode to correspond to specification (Bean Huo)
- Add patch #5: "scsi: ufs: cleanup WriteBooster feature"

Stanley Chu (8):
scsi: ufs: enable WriteBooster on some pre-3.1 UFS devices
scsi: ufs: introduce fixup_dev_quirks vops
scsi: ufs: export ufs_fixup_device_setup() function
scsi: ufs-mediatek: add fixup_dev_quirks vops
scsi: ufs: add "index" in parameter list of ufshcd_query_flag()
scsi: ufs: add LU Dedicated buffer mode support for WriteBooster
scsi: ufs-mediatek: enable WriteBooster capability
scsi: ufs: cleanup WriteBooster feature

 drivers/scsi/ufs/ufs-mediatek.c |  25 ++++-
 drivers/scsi/ufs/ufs-sysfs.c    |  11 ++-
 drivers/scsi/ufs/ufs.h          |  10 ++
 drivers/scsi/ufs/ufs_quirks.h   |   7 ++
 drivers/scsi/ufs/ufshcd.c       | 166 +++++++++++++++++++++-----------
 drivers/scsi/ufs/ufshcd.h       |  19 +++-
 6 files changed, 176 insertions(+), 62 deletions(-)
Signature · 1 line
2.18.0