scsi: ufs: support LU Dedicated buffer mode for WriteBooster
Status from this message: Applied to 5.8/scsi-queue, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest8 patches 3 repliesApplied
- v78 patches 4 repliesSuperseded
- v68 patches 1 replySuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 8 patches | 11 replies | Superseded | |
| v4 | 8 patches | 2 replies | Superseded | |
| v3 | 5 patches | 7 replies | Superseded | |
| v2 | 5 patches | 6 replies | Superseded | |
| v1 | 4 patches | 5 replies | Superseded |
Changes in v8 from the cover letter
- In exported funtion ufshcd_fixup_dev_quirks(), add null checking for parameter "fixups" (Avri Altman)
Patches in v8 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | scsi: ufs: enable WriteBooster on some pre-3.1 UFS devicesdrivers/ drivers/ | +49 | 0 replies | |
| 2/8 | scsi: ufs: introduce fixup_dev_quirks vopsdrivers/ drivers/ | +18 | 0 replies | |
| 3/8 | scsi: ufs: export ufs_fixup_device_setup() functiondrivers/ drivers/ | +8 | 0 replies | |
| 4/8 | scsi: ufs-mediatek: add fixup_dev_quirks vopsdrivers/ | +19 | 0 replies | |
| 5/8 | scsi: ufs: add "index" in parameter list of ufshcd_query_flag()drivers/ drivers/ drivers/ | +17 | 0 replies | |
| 6/8 | scsi: ufs: add LU Dedicated buffer mode support for WriteBoosterdrivers/ drivers/ drivers/ +1 more | +66 | 0 replies | |
| 7/8 | scsi: ufs-mediatek: enable WriteBooster capabilitydrivers/ | +3 | 0 replies | |
| 8/8 | scsi: ufs: cleanup WriteBooster featuredrivers/ | +7 | 1 reply |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Avri Altman | Bean Huo | Can Guo | Asutosh Das |
|---|---|---|---|---|
| 1/8 | R-b | |||
| 2/8 | R-b | |||
| 3/8 | R-b | |||
| 4/8 | R-b | |||
| 5/8 | R-b | R-b | R-b | |
| 6/8 | R-b | R-b | ||
| 7/8 | R-b | |||
| 8/8 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v8 0/8] scsi: ufs: support LU Dedicated buffer mode for WriteBooster
Hi,
This patchset adds LU dedicated buffer mode support for WriteBooster. In the meanwhile, enable WriteBooster capability on MediaTek UFS platforms.
v7 -> v8:
- In exported funtion ufshcd_fixup_dev_quirks(), add null checking for parameter "fixups" (Avri Altman)
v6 -> v7:
- Add device descriptor length check in ufshcd_wb_probe() back to prevent out-of-boundary access in ufshcd_wb_probe()
- Fix the check of device descriptor length (Avri Altman)
- Provide a new ufs_fixup_device_setup() function to pack both device fixup methods by general quirk table and vendor-specific way (Avri Altman)
v5 -> v6:
- Remove device descriptor length check in ufshcd_wb_probe()
v4 -> v5:
- Check LUN ID for available WriteBooster buffer only from 0 to 7 according to spec (Avri Altman)
- Skip checking any possible errors from ufshcd_read_unit_desc_param(hba, lun, UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS) in ufshcd_wb_probe() and check returned d_lu_wb_buf_alloc (shall be zero if error happens) (Avri Altman)
v3 -> v4:
- Introduce "fixup_dev_quirks" vops to allow vendors to fix and modify device quirks, and provide an initial vendor-specific device quirk table on MediaTek UFS platforms
- Avoid relying on common device quirk table for pre-3.1 UFS device with non-standard WriteBooster support (Can Guo)
- Fix comments for ufshcd_wb_probe() (Can Guo)
- Make ufshcd_wb_get_flag_index() inline and fix ufshcd_is_wb_flags() (Avri Altman)
v2 -> v3:
- Introduce a device quirk to support WriteBooster in pre-3.1 UFS devices (Avri Altman)
- Fix WriteBooster related sysfs nodes. Now all WriteBooster related sysfs nodes are specifically mapped to the LUN with WriteBooster enabled in LU Dedicated buffer mode (Avri Altman)
v1 -> v2:
- Change the definition name of WriteBooster buffer mode to correspond to specification (Bean Huo)
- Add patch #5: "scsi: ufs: cleanup WriteBooster feature"
Stanley Chu (8):
scsi: ufs: enable WriteBooster on some pre-3.1 UFS devices
scsi: ufs: introduce fixup_dev_quirks vops
scsi: ufs: export ufs_fixup_device_setup() function
scsi: ufs-mediatek: add fixup_dev_quirks vops
scsi: ufs: add "index" in parameter list of ufshcd_query_flag()
scsi: ufs: add LU Dedicated buffer mode support for WriteBooster
scsi: ufs-mediatek: enable WriteBooster capability
scsi: ufs: cleanup WriteBooster feature
drivers/scsi/ufs/ufs-mediatek.c | 25 ++++- drivers/scsi/ufs/ufs-sysfs.c | 11 ++- drivers/scsi/ufs/ufs.h | 10 ++ drivers/scsi/ufs/ufs_quirks.h | 7 ++ drivers/scsi/ufs/ufshcd.c | 166 +++++++++++++++++++++----------- drivers/scsi/ufs/ufshcd.h | 19 +++- 6 files changed, 176 insertions(+), 62 deletions(-)
Signature · 1 line
2.18.0