Skip to content

target/arm: Remove access_el3_aa32ns_aa64any()

Edgar E. Iglesias qemu-arm qemu-devel 3 versions – Applied

Status from this message: Applied to target-arm.next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 1 replyApplied
  2. v21 patch 1 replySuperseded
  3. v11 patch 2 repliesSuperseded

Changes in v3 from the cover letter

* Update commit message and cover letter to reflect that access_el3_aa32ns_aa64any is now being removed

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/1target/arm: Drop access_el3_aa32ns_aa64any()target/arm/helper.c+7 -230 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/1] target/arm: Remove access_el3_aa32ns_aa64any()

From: "Edgar E. Iglesias" <[email protected]>

Hi,

Laurent reported hitting the assert in access_el3_aa32ns() when accessing 32-bit versions of some of the virtualization regs when EL3 is 64-bit.

I think we got this wrong back then and it seems to me like we should merge access_el3_aa32ns and access_el3_aa32ns_aa64_any() and always call the merged function to handle both aa32-only cases and mixed aa32/aa64.

Cheers,
Edgar

ChangeLog:

v2 -> v3:
* Update commit message and cover letter to reflect that access_el3_aa32ns_aa64any is now being removed

v1 -> v2:
* Keep access_el3_aa32ns in favor of access_el3_aa32ns_aa64any
* Simplify description of access_el3_aa32ns
* Tweak secure aa32-el3 check in access_el3_aa32ns as suggested by Peter

Edgar E. Iglesias (1):
target/arm: Drop access_el3_aa32ns_aa64any()

 target/arm/helper.c | 30 +++++++-----------------------
 1 file changed, 7 insertions(+), 23 deletions(-)
Signature · 1 line
2.20.1