Skip to content

cocci: Add cast attributes to C and SmPL ASTs

Jaskaran Singh cocci linux-kernel-mentees 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest32 patches 0 repliesNew
  2. v232 patches 0 repliesSuperseded
  3. v132 patches 10 repliesSuperseded

Changes in v3 from the cover letter

--------------
Rebase as follows:
v3 of "cocci: Add Parameter attributes to SmPL"[2] v3 of "cocci: Improve C parsing of attributes"[3] gitlab master branch (ffb87d9d)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32parsing_c: parser: Pass attribute list from type_nameocaml/coccilib.mli parsing_c/parse_c.ml parsing_c/parser_c.mly+21 -100 replies
2/32parsing_cocci: ast0_cocci: Add cast attributesparsing_cocci/ast0_cocci.ml parsing_cocci/ast0_cocci.mli+4 -40 replies
3/32parsing_cocci: parser: Parse cast attributesparsing_cocci/parser_cocci_menhir.mly+5 -40 replies
4/32parsing_cocci: visitor_ast0: Visit cast attributesparsing_cocci/visitor_ast0.ml+4 -20 replies
5/32parsing_cocci: unparse_ast0: Reflect cast attributesparsing_cocci/unparse_ast0.ml+3 -10 replies
6/32parsing_cocci: index: Reflect Cast attributesparsing_cocci/index.ml+1 -10 replies
7/32parsing_cocci: iso_pattern: Reflect Cast attributesparsing_cocci/iso_pattern.ml+9 -30 replies
8/32parsing_cocci: type_infer: Reflect Cast attributesparsing_cocci/type_infer.ml+1 -10 replies
9/32parsing_cocci: arity: Reflect Cast attributesparsing_cocci/arity.ml+5 -30 replies
10/32parsing_cocci: check_meta: Reflect Cast attributesparsing_cocci/check_meta.ml+2 -10 replies
11/32parsing_cocci: compute_lines: Reflect Cast attributesparsing_cocci/compute_lines.ml+3 -20 replies
12/32parsing_cocci: context_neg: Reflect Cast attributesparsing_cocci/context_neg.ml+1 -10 replies
13/32parsing_cocci: single_statement: Reflect Cast attributesparsing_cocci/single_statement.ml+1 -10 replies
14/32parsing_cocci: ast_cocci: Add cast attributesparsing_cocci/ast_cocci.ml parsing_cocci/ast_cocci.mli+4 -40 replies
15/32parsing_cocci: visitor_ast: Visit cast attributesparsing_cocci/visitor_ast.ml+6 -40 replies
16/32parsing_cocci: pretty_print_cocci: Print cast attributesparsing_cocci/pretty_print_cocci.ml+3 -10 replies
17/32parsing_cocci: ast0toast: Reflect Cast attributesparsing_cocci/ast0toast.ml+3 -20 replies
18/32parsing_cocci: disjdistr: Reflect Cast attributesparsing_cocci/disjdistr.ml+3 -20 replies
19/32parsing_cocci: unify_ast: Reflect Cast attributesparsing_cocci/unify_ast.ml+4 -20 replies
20/32parsing_c: ast_c: Add Cast attributesparsing_c/ast_c.ml parsing_c/ast_c.mli+2 -20 replies
21/32parsing_c: parser: Parse Cast attributesparsing_c/parser_c.mly+2 -10 replies
22/32parsing_c: pretty_print_c: Reflect Cast attributesparsing_c/pretty_print_c.ml+4 -30 replies
23/32parsing_c: type_annoter_c: Reflect Cast attributesparsing_c/type_annoter_c.ml+2 -22 replies
24/32parsing_c: unparse_cocci: Reflect Cast attributesparsing_c/unparse_cocci.ml+4 -20 replies
25/32parsing_c: visitor_c: Visit Cast attributesparsing_c/visitor_c.ml+9 -20 replies
26/32engine: check_exhaustive_pattern: Reflect Cast attributesengine/check_exhaustive_pattern.ml+1 -10 replies
27/32engine: cocci_vs_c: Match Cast attributesengine/cocci_vs_c.ml+17 -70 replies
28/32ocaml: coccilib: Reflect Cast attributesocaml/coccilib.mli+3 -30 replies
29/32tools: spgen: Reflect Cast attrstools/spgen/source/position_generator.ml+2 -20 replies
30/32tests: Add test case to check cast attribute allminustests/remove_cast_attr_allminus.c tests/remove_cast_attr_allminus.cocci tests/remove_cast_attr_allminus.res+29 -00 replies
31/32tests: Add test case to remove cast attributestests/remove_cast_attr.c tests/remove_cast_attr.cocci tests/remove_cast_attr.res+30 -00 replies
32/32tests: Add test case to detect cast attributestests/detect_cast_attr.c tests/detect_cast_attr.cocci tests/detect_cast_attr.res+31 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Cocci] [PATCH v3 00/32] cocci: Add cast attributes to C and SmPL ASTs

This patch series aims to add cast attributes to the C and SmPL ASTs, and match them in C source code. This is a continuation of the series "cocci:
Improve C parsing of attributes"[1].

Three test cases are included:

- detect_cast_attr: Test case to detect a parameter attribute.

- remove_cast_attr: Test case to remove a parameter attribute as per the given SmPL.

- remove_cast_attr_allminus: Test case to replace a type in a cast and checking if the attribute is removed as well.

Changes in v3:
--------------
Rebase as follows:
v3 of "cocci: Add Parameter attributes to SmPL"[2] v3 of "cocci: Improve C parsing of attributes"[3] gitlab master branch (ffb87d9d)

Changes in v2:
--------------
parsing_c: parser: Pass attribute list from type_name
- Warn about dropped attributes in typeof and sizeof productions

parsing_cocci: parser: Parse cast attributes
- Mention in commit message that cast attributes are matched anywhere in a cast.

parsing_cocci: arity: Reflect Cast attributes
- Apply mcode2arity on attributes as well.

parsing_cocci: visitor_ast: Visit cast attributes
- Typo in commit message (AST0 -> AST).

parsing_c: pretty_print_c: Reflect Cast attributes
- Less space in front of [

parsing_c: ast_c: Add Cast attributes
- Switch places of expression and attributes in Cast type.

parsing_c: parser: Parse Cast attributes
- Switch places of expression and attributes in Cast type.

parsing_c: pretty_print_c: Reflect Cast attributes
- Switch places of expression and attributes in Cast type.
- Change printing order of cast elements.

parsing_c: type_annoter_c: Reflect Cast attributes
- Switch places of expression and attributes in Cast type.

parsing_c: visitor_c: Visit Cast attributes
- Switch places of expression and attributes in Cast type.
- Change visitor order of cast elements.

engine: cocci_vs_c: Match Cast attributes
- Switch places of expression and attributes in C AST Cast type.

ocaml: coccilib: Reflect Cast attributes
- Switch places of expression and attributes in C AST Cast type.

[1]https://www.mail-archive.com/[email protected]/msg07133.html [2]https://www.mail-archive.com/[email protected]/msg07311.html [3]https://www.mail-archive.com/[email protected]/msg07439.html

Jaskaran Singh (32):
parsing_c: parser: Pass attribute list from type_name
parsing_cocci: ast0_cocci: Add cast attributes
parsing_cocci: parser: Parse cast attributes
parsing_cocci: visitor_ast0: Visit cast attributes
parsing_cocci: unparse_ast0: Reflect cast attributes
parsing_cocci: index: Reflect Cast attributes
parsing_cocci: iso_pattern: Reflect Cast attributes
parsing_cocci: type_infer: Reflect Cast attributes
parsing_cocci: arity: Reflect Cast attributes
parsing_cocci: check_meta: Reflect Cast attributes
parsing_cocci: compute_lines: Reflect Cast attributes
parsing_cocci: context_neg: Reflect Cast attributes
parsing_cocci: single_statement: Reflect Cast attributes
parsing_cocci: ast_cocci: Add cast attributes
parsing_cocci: visitor_ast: Visit cast attributes
parsing_cocci: pretty_print_cocci: Print cast attributes
parsing_cocci: ast0toast: Reflect Cast attributes
parsing_cocci: disjdistr: Reflect Cast attributes
parsing_cocci: unify_ast: Reflect Cast attributes
parsing_c: ast_c: Add Cast attributes
parsing_c: parser: Parse Cast attributes
parsing_c: pretty_print_c: Reflect Cast attributes
parsing_c: type_annoter_c: Reflect Cast attributes
parsing_c: unparse_cocci: Reflect Cast attributes
parsing_c: visitor_c: Visit Cast attributes
engine: check_exhaustive_pattern: Reflect Cast attributes
engine: cocci_vs_c: Match Cast attributes
ocaml: coccilib: Reflect Cast attributes
tools: spgen: Reflect Cast attrs
tests: Add test case to check cast attribute allminus
tests: Add test case to remove cast attributes
tests: Add test case to detect cast attributes

 engine/check_exhaustive_pattern.ml       |    2 +-
 engine/cocci_vs_c.ml                     |   24 +++++++++++++++++-------
 ocaml/coccilib.mli                       |    9 +++++----
 parsing_c/ast_c.ml                       |    2 +-
 parsing_c/ast_c.mli                      |    2 +-
 parsing_c/parse_c.ml                     |    4 +++-
 parsing_c/parser_c.mly                   |   27 ++++++++++++++++++---------
 parsing_c/pretty_print_c.ml              |    7 ++++---
 parsing_c/type_annoter_c.ml              |    4 ++--
 parsing_c/unparse_cocci.ml               |    6 ++++--
 parsing_c/visitor_c.ml                   |   11 +++++++++--
 parsing_cocci/arity.ml                   |    8 +++++---
 parsing_cocci/ast0_cocci.ml              |    4 ++--
 parsing_cocci/ast0_cocci.mli             |    4 ++--
 parsing_cocci/ast0toast.ml               |    5 +++--
 parsing_cocci/ast_cocci.ml               |    4 ++--
 parsing_cocci/ast_cocci.mli              |    4 ++--
 parsing_cocci/check_meta.ml              |    3 ++-
 parsing_cocci/compute_lines.ml           |    5 +++--
 parsing_cocci/context_neg.ml             |    2 +-
 parsing_cocci/disjdistr.ml               |    5 +++--
 parsing_cocci/index.ml                   |    2 +-
 parsing_cocci/iso_pattern.ml             |   12 +++++++++---
 parsing_cocci/parser_cocci_menhir.mly    |    9 +++++----
 parsing_cocci/pretty_print_cocci.ml      |    4 +++-
 parsing_cocci/single_statement.ml        |    2 +-
 parsing_cocci/type_infer.ml              |    2 +-
 parsing_cocci/unify_ast.ml               |    6 ++++--
 parsing_cocci/unparse_ast0.ml            |    4 +++-
 parsing_cocci/visitor_ast.ml             |   10 ++++++----
 parsing_cocci/visitor_ast0.ml            |    6 ++++--
 tests/detect_cast_attr.c                 |   10 ++++++++++
 tests/detect_cast_attr.cocci             |   11 +++++++++++
 tests/detect_cast_attr.res               |   10 ++++++++++
 tests/remove_cast_attr.c                 |   10 ++++++++++
 tests/remove_cast_attr.cocci             |   10 ++++++++++
 tests/remove_cast_attr.res               |   10 ++++++++++
 tests/remove_cast_attr_allminus.c        |   10 ++++++++++
 tests/remove_cast_attr_allminus.cocci    |    9 +++++++++
 tests/remove_cast_attr_allminus.res      |   10 ++++++++++
 tools/spgen/source/position_generator.ml |    4 ++--
 41 files changed, 219 insertions(+), 74 deletions(-)

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees