More truncate improvements
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | gluster: Drop useless has_zero_init callbackblock/ | +0 | 0 replies | |
| 2/9 | file-win32: Support BDRV_REQ_ZERO_WRITE for truncateblock/ | +3 | 0 replies | |
| 3/9 | nfs: Support BDRV_REQ_ZERO_WRITE for truncateblock/ | +3 | 0 replies | |
| 4/9 | rbd: Support BDRV_REQ_ZERO_WRITE for truncateblock/ | +3 | 0 replies | |
| 5/9 | sheepdog: Support BDRV_REQ_ZERO_WRITE for truncateblock/ | +1 | 0 replies | |
| 6/9 | ssh: Support BDRV_REQ_ZERO_WRITE for truncateblock/ | +4 | 1 reply | |
| 7/9 | parallels: Rework truncation logicblock/ | +15 | 1 reply | |
| 8/9 | vhdx: Rework truncation logicblock/ | +51 | 0 replies | |
| 9/9 | block: Drop unused .bdrv_has_zero_init_truncateblock.c block/ block/ +9 more | +0 | 1 reply |
Reviews trailers per patch
3 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Vladimir Sementsov-Ogievskiy | Alberto Garcia | Richard W.M. Jones | Kevin Wolf | Denis V. Lunev |
|---|---|---|---|---|---|
| Series | R-b | ||||
| 1/9 | R-b | R-b | |||
| 2/9 | |||||
| 3/9 | |||||
| 4/9 | |||||
| 5/9 | |||||
| 6/9 | R-b | ||||
| 7/9 | R-b | ||||
| 8/9 | |||||
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH 0/9] More truncate improvements
Based-on: <[email protected]> [PATCH v7 00/10] block: Fix resize (extending) of short overlays
After reviewing Kevin's work, I questioned if we had a redundancy with bdrv_has_zero_init_truncate. It turns out we do, and this is the result.
Patch 1 has been previously posted [1] and reviewed, the rest is new. I did not address Neils' comment that modern gluster also always 0-initializes [2], as I am not set up to verify it (my changes to the other drivers are semantic no-ops, so I don't feel as bad about posting them with less rigourous testing).
[1] https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg08070.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04266.html
Eric Blake (9):
gluster: Drop useless has_zero_init callback
file-win32: Support BDRV_REQ_ZERO_WRITE for truncate
nfs: Support BDRV_REQ_ZERO_WRITE for truncate
rbd: Support BDRV_REQ_ZERO_WRITE for truncate
sheepdog: Support BDRV_REQ_ZERO_WRITE for truncate
ssh: Support BDRV_REQ_ZERO_WRITE for truncate
parallels: Rework truncation logic
vhdx: Rework truncation logic
block: Drop unused .bdrv_has_zero_init_truncate
include/block/block.h | 1 - include/block/block_int.h | 7 --- block.c | 21 --------- block/file-posix.c | 1 - block/file-win32.c | 4 +- block/gluster.c | 14 ------ block/nfs.c | 4 +- block/parallels.c | 23 ++++++---- block/qcow2.c | 1 - block/qed.c | 1 - block/raw-format.c | 6 --- block/rbd.c | 4 +- block/sheepdog.c | 4 +- block/ssh.c | 5 ++- block/vhdx.c | 89 ++++++++++++++++++++++----------------- 15 files changed, 80 insertions(+), 105 deletions(-)
Signature · 1 line
2.26.2