Skip to content

RFC block: add error handling for *add_disk*()

Luis Chamberlain linux-block lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6block: refcount the request_queue early in __device_add_disk()block/genhd.c+6 -60 replies
2/6block: move disk announce work from register_disk() to a helperblock/genhd.c+19 -110 replies
3/6block: move disk invalidation from del_gendisk() into a helperblock/genhd.c+45 -400 replies
4/6block: move disk unregistration work from del_gendisk() to a helperblock/genhd.c+24 -170 replies
5/6block: add initial error handling for *add_disk()* and friendsblock/blk-integrity.c block/blk-sysfs.c block/blk.h +2 more+171 -800 replies
6/6loop: add error handling support for add_disk()drivers/block/loop.c+6 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC v1 0/6] block: add error handling for *add_disk*()

While working on some blktrace races I noticed that we don't do error handling on *add_disk*() and friends. This is my initial work on that.

This is based on linux-next tag next-20200428, you can also get this on my branch 20200428-block-fixes [0].

Let me know what you think.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200428-blktrace-fixes

Luis Chamberlain (6):
block: refcount the request_queue early in __device_add_disk()
block: move disk announce work from register_disk() to a helper
block: move disk invalidation from del_gendisk() into a helper
block: move disk unregistration work from del_gendisk() to a helper
block: add initial error handling for *add_disk()* and friends
loop: add error handling support for add_disk()

 block/blk-integrity.c |  13 +-
 block/blk-sysfs.c     |   7 +-
 block/blk.h           |   5 +-
 block/genhd.c         | 366 +++++++++++++++++++++++++++---------------
 drivers/block/loop.c  |   7 +-
 include/linux/genhd.h |  16 +-
 6 files changed, 265 insertions(+), 149 deletions(-)
Signature · 1 line
2.25.1