Skip to content

audio: deprecate -soundhw

Gerd Hoffmann qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest20 patches 1 replyIn review
  2. v420 patches 2 repliesSuperseded
  3. v319 patches 9 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v213 patches10 repliesSuperseded
v112 patches6 repliesSuperseded

Changes in v5 from the cover letter

- spell fixes (Eric).
- fix mips build error.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20stubs: add isa_create_simplestubs/Makefile.objs stubs/isa-bus.c+8 -00 replies
2/20stubs: add pci_create_simplestubs/Makefile.objs stubs/pci-bus.c+8 -00 replies
3/20audio: add deprecated_register_soundhwhw/audio/soundhw.c include/hw/audio/soundhw.h+25 -10 replies
4/20audio: deprecate -soundhw ac97hw/audio/ac97.c qdev-monitor.c+3 -70 replies
5/20audio: deprecate -soundhw es1370hw/audio/es1370.c qdev-monitor.c+3 -70 replies
6/20audio: deprecate -soundhw adlibhw/audio/adlib.c+1 -70 replies
7/20audio: deprecate -soundhw cs4231ahw/audio/cs4231a.c+1 -70 replies
8/20audio: deprecate -soundhw gushw/audio/gus.c+1 -70 replies
9/20audio: deprecate -soundhw sb16hw/audio/sb16.c+2 -70 replies
10/20audio: deprecate -soundhw hdahw/audio/intel-hda.c+3 -00 replies
11/20pc_basic_device_init: pass PCMachineStatehw/i386/pc.c hw/i386/pc_piix.c hw/i386/pc_q35.c +1 more+6 -41 reply
12/20pc_basic_device_init: drop has_pit arghw/i386/pc.c hw/i386/pc_piix.c hw/i386/pc_q35.c +1 more+3 -50 replies
13/20pc_basic_device_init: drop no_vmport arghw/i386/pc.c hw/i386/pc_piix.c hw/i386/pc_q35.c +1 more+1 -50 replies
14/20softmmu: initialize spice and audio earliersoftmmu/vl.c+6 -60 replies
15/20audio: rework pcspk_init()hw/i386/pc.c hw/isa/i82378.c hw/mips/jazz.c +1 more+4 -80 replies
16/20audio: create pcspk device earlyhw/i386/pc.c include/hw/i386/pc.h+3 -10 replies
17/20audio: deprecate -soundhw pcspkhw/audio/pcspk.c hw/i386/pc.c+23 -30 replies
18/20audio: add soundhw deprecation noticedocs/system/deprecated.rst+9 -00 replies
19/20pcspk: update docs/system/target-i386-desc.rst.incdocs/system/target-i386-desc.rst.inc+12 -10 replies
20/20audio: set default value for pcspk.iobase propertyhw/audio/pcspk.c include/hw/audio/pcspk.h+2 -60 replies

Reviews trailers per patch

2 of 20 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/20R-b T-b
2/20R-b T-b
3/20
4/20
5/20
6/20
7/20
8/20
9/20
10/20
11/20
12/20
13/20
14/20
15/20
16/20
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/20] audio: deprecate -soundhw

v2:
- use g_assert_not_reached() for stubs.
- add deprecation notice.

v3:
- rebase to latest master.
- adapt to armbru's device initialization changes.

v4:
- reorder patches, drop temporary -global setup, go straight to -machine pcspk-audiodev= instead.
- update error messages and documentation accordingly.

v5:
- spell fixes (Eric).
- fix mips build error.

Gerd Hoffmann (20):
stubs: add isa_create_simple
stubs: add pci_create_simple
audio: add deprecated_register_soundhw
audio: deprecate -soundhw ac97
audio: deprecate -soundhw es1370
audio: deprecate -soundhw adlib
audio: deprecate -soundhw cs4231a
audio: deprecate -soundhw gus
audio: deprecate -soundhw sb16
audio: deprecate -soundhw hda
pc_basic_device_init: pass PCMachineState
pc_basic_device_init: drop has_pit arg
pc_basic_device_init: drop no_vmport arg
softmmu: initialize spice and audio earlier
audio: rework pcspk_init()
audio: create pcspk device early
audio: deprecate -soundhw pcspk
audio: add soundhw deprecation notice
pcspk: update docs/system/target-i386-desc.rst.inc
audio: set default value for pcspk.iobase property

 include/hw/audio/pcspk.h             | 12 ++----------
 include/hw/audio/soundhw.h           |  2 ++
 include/hw/i386/pc.h                 |  6 +++---
 hw/audio/ac97.c                      |  9 ++-------
 hw/audio/adlib.c                     |  8 +-------
 hw/audio/cs4231a.c                   |  8 +-------
 hw/audio/es1370.c                    |  9 ++-------
 hw/audio/gus.c                       |  8 +-------
 hw/audio/intel-hda.c                 |  3 +++
 hw/audio/pcspk.c                     | 26 ++++++++++++++++++++++----
 hw/audio/sb16.c                      |  9 ++-------
 hw/audio/soundhw.c                   | 24 +++++++++++++++++++++++-
 hw/i386/pc.c                         | 14 ++++++++------
 hw/i386/pc_piix.c                    |  3 +--
 hw/i386/pc_q35.c                     |  3 +--
 hw/isa/i82378.c                      |  2 +-
 hw/mips/jazz.c                       |  2 +-
 qdev-monitor.c                       |  2 ++
 softmmu/vl.c                         | 12 ++++++------
 stubs/isa-bus.c                      |  7 +++++++
 stubs/pci-bus.c                      |  7 +++++++
 docs/system/deprecated.rst           |  9 +++++++++
 docs/system/target-i386-desc.rst.inc | 13 ++++++++++++-
 stubs/Makefile.objs                  |  2 ++
 24 files changed, 121 insertions(+), 79 deletions(-)
 create mode 100644 stubs/isa-bus.c
 create mode 100644 stubs/pci-bus.c
Signature · 1 line
2.18.4