Skip to content

backup: Make sure that source and target size match

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 8 repliesIn review
  2. v13 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Fixed iotest 283
- Corrected commit message for patch 3 [Vladimir]
- Fixed permissions for the source node, too
- Refactored the test case to avoid some duplication [Vladimir]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4iotests/283: Use consistent size for source and targettests/qemu-iotests/283 tests/qemu-iotests/283.out+6 -21 reply
2/4backup: Improve error for bdrv_getlength() failureblock/backup.c+2 -20 replies
3/4backup: Make sure that source and target size matchblock/backup-top.c block/backup.c+22 -65 replies
4/4iotests: Backup with different source/target sizetests/qemu-iotests/055 tests/qemu-iotests/055.out+42 -41 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyAlberto Garcia
1/4R-b
2/4R-b R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] backup: Make sure that source and target size match

v2:
- Fixed iotest 283
- Corrected commit message for patch 3 [Vladimir]
- Fixed permissions for the source node, too
- Refactored the test case to avoid some duplication [Vladimir]

Kevin Wolf (4):
iotests/283: Use consistent size for source and target
backup: Improve error for bdrv_getlength() failure
backup: Make sure that source and target size match
iotests: Backup with different source/target size

 block/backup-top.c         | 14 ++++++++-----
 block/backup.c             | 18 +++++++++++++---
 tests/qemu-iotests/055     | 42 ++++++++++++++++++++++++++++++++++++--
 tests/qemu-iotests/055.out |  4 ++--
 tests/qemu-iotests/283     |  6 +++++-
 tests/qemu-iotests/283.out |  2 +-
 6 files changed, 72 insertions(+), 14 deletions(-)
Signature · 1 line
2.25.3