Skip to content

ARM: imx: Fix reset in SPL

Harald Seiler u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ARM: imx8m: Do not define do_reset() if sysreset is enabledarch/arm/mach-imx/imx8m/soc.c+1 -11 reply
2/8ARM: imx8m: Fix indentation of reset_cpu() functionarch/arm/mach-imx/imx8m/soc.c+10 -101 reply
3/8ARM: imx8m: Don't use the addr parameter of reset_cpu()arch/arm/mach-imx/imx8m/soc.c+1 -42 replies
3/8ARM: imx8m: Don't use the addr parameter of reset_cpu()+0 -00 replies
4/8ARM: imx8m: Fix reset in SPL on NXP iMX8MM EVKarch/arm/dts/imx8mm-evk-u-boot.dtsi board/freescale/imx8mm_evk/spl.c configs/imx8mm_evk_defconfig+17 -91 reply
5/8ARM: imx8m: Fix reset in SPL on NXP iMX8MN EVKarch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi board/freescale/imx8mn_evk/spl.c configs/imx8mn_ddr4_evk_defconfig+17 -91 reply
6/8ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVKarch/arm/dts/imx8mp-evk-u-boot.dtsi board/freescale/imx8mp_evk/spl.c configs/imx8mp_evk_defconfig+16 -93 replies
6/8ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK+0 -01 reply
6/8ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK+0 -01 reply
6/8ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK+0 -01 reply
7/8ARM: imx8m: Fix reset in SPL on Toradex iMX8MM Verdinarch/arm/dts/imx8mm-verdin-u-boot.dtsi board/toradex/verdin-imx8mm/spl.c configs/verdin-imx8mm_defconfig+17 -94 replies
8/8ARM: reset: use do_reset in SPL/TPL if SYSRESET was not enabled for themarch/arm/lib/Makefile+1 -10 replies

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFabio EstevamOleksandr SuvorovIgor Opaniuk
SeriesR-b
1/8
2/8
3/8
3/8
4/8
5/8
6/8
6/8
6/8
6/8
7/8R-b A-b A-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] ARM: imx: Fix reset in SPL

This series is a merge of "ARM: Fix reset in SPL if SYSRESET is not used" [1] and "ARM: imx: Do not define do_reset() if sysreset is enabled" [2] as the two solve the same problem.

The first of the two was sent to originally to fix a problem not related to imx8m (see the last patch of this new series, "ARM: reset: use do_reset in SPL/TPL if SYSRESET was not enabled for them"). However, this broke imx8m boards as they define do_reset() in board code which was the reason for adding the imx8m patches.

Now, Marek sent the latter series which solves the specific issues of the imx8m boards properly by converting them to use DM_SYSRESET in SPL.

This approach is better than what Claudius and I did originally so I've dropped our (non-DM) fixes for the imx8m boards and added Marek's patches instead. I have, however, kept the fixes for the generic code so if anyone would go back to using the non-DM version, it would also work (and not be part of the tree while silently being broken).

[1]: https://patchwork.ozlabs.org/project/uboot/list/?series=162379
[2]: https://patchwork.ozlabs.org/project/uboot/list/?series=173249

Claudius Heine (2):
ARM: imx8m: Don't use the addr parameter of reset_cpu()
ARM: reset: use do_reset in SPL/TPL if SYSRESET was not enabled for
them

Harald Seiler (1):
ARM: imx8m: Fix indentation of reset_cpu() function

Marek Vasut (5):
ARM: imx8m: Do not define do_reset() if sysreset is enabled
ARM: imx8m: Fix reset in SPL on NXP iMX8MM EVK
ARM: imx8m: Fix reset in SPL on NXP iMX8MN EVK
ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK
ARM: imx8m: Fix reset in SPL on Toradex iMX8MM Verdin

 arch/arm/dts/imx8mm-evk-u-boot.dtsi      | 12 ++++++++++++
 arch/arm/dts/imx8mm-verdin-u-boot.dtsi   | 12 ++++++++++++
 arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 12 ++++++++++++
 arch/arm/dts/imx8mp-evk-u-boot.dtsi      | 12 ++++++++++++
 arch/arm/lib/Makefile                    |  2 +-
 arch/arm/mach-imx/imx8m/soc.c            | 21 +++++++++------------
 board/freescale/imx8mm_evk/spl.c         |  9 ---------
 board/freescale/imx8mn_evk/spl.c         |  9 ---------
 board/freescale/imx8mp_evk/spl.c         |  9 ---------
 board/toradex/verdin-imx8mm/spl.c        |  9 ---------
 configs/imx8mm_evk_defconfig             |  5 +++++
 configs/imx8mn_ddr4_evk_defconfig        |  5 +++++
 configs/imx8mp_evk_defconfig             |  4 ++++
 configs/verdin-imx8mm_defconfig          |  5 +++++
 14 files changed, 77 insertions(+), 49 deletions(-)
Signature · 1 line
2.26.2