Skip to content

Fix Navi cards crashing with FP exception on 5.6+

Daniel Kolesa amd-gfx 1 version Applied

Status from this message: Applied. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/1drm/amd/display: work around fp code being emitted outside of DC_FP_START/ENDdrivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c+23 -81 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] Fix Navi cards crashing with FP exception on 5.6+

This is not a real fix, but rather a workaround that should be applied to the 5.6 tree and newer. The idea here is to work around the compiler emitting FP instructions outside the DC_FP_START/DC_FP_END blocks, which it currently does, which causes crashes at least on ppc64le.

A proper solution would be to move all the floating point code into its own files, then compile those with hard-float and strictly wrap all calls into those with the DC_FP_START/DC_FP_END blocks, with the rest of the code being compiled without floating point, but that's too extensive of a change to do, and would not be possible in a stable tree.

The proper solution is already being discussed, it seems:

https://lore.kernel.org/lkml/CAG48ez2Sx4ELkM94aD_h_J7K7KBOeuGmvZLKRkg3n_f2WoZ_cg@mail.gmail.com/

Daniel Kolesa (1):
drm/amd/display: work around fp code being emitted outside of
DC_FP_START/END

 .../drm/amd/display/dc/dcn20/dcn20_resource.c | 31 ++++++++++++++-----
 1 file changed, 23 insertions(+), 8 deletions(-)
Signature · 6 lines
2.26.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx