stmmac: intel: Fixes and cleanups after dwmac-intel split
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Changes in v3 from the cover letter
- added the cover letter (David)
- appended separate fix as a first patch
- marked patches 2 and 3 with Fixes tag
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | stmmac: intel: Fix kernel crash due to wrong error pathdrivers/ | +3 | 0 replies | |
| 2/7 | stmmac: intel: Fix clock handling on error and remove pathsdrivers/ drivers/ | +16 | 0 replies | |
| 3/7 | stmmac: intel: Remove unnecessary loop for PCI BARsdrivers/ | +5 | 0 replies | |
| 4/7 | stmmac: intel: Convert to use pci_alloc_irq_vectors() APIdrivers/ | +8 | 0 replies | |
| 5/7 | stmmac: intel: Eliminate useless conditions and variablesdrivers/ | +2 | 0 replies | |
| 6/7 | stmmac: intel: Fix indentation to put on one line affected codedrivers/ | +32 | 0 replies | |
| 7/7 | stmmac: intel: Place object in the Makefile according to the orderdrivers/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/7] stmmac: intel: Fixes and cleanups after dwmac-intel split
Seems the split of dwmac-intel didn't go well and on top of that new functionality in the driver has not been properly tested.
Patch 1 fixes a nasty kernel crash due to missed error handling. Patches 2 and 3 fix the incorrect split (clock and PCI bar handling).
Patch 4 converts driver to use new PCI IRQ allocation API.
The rest is a set of clean ups that may have been done in the initial submission.
Series has been tested on couple of Elkhart Lake platforms with different behaviour of ethernet hardware.
Changelog v3:
- added the cover letter (David)
- appended separate fix as a first patch
- marked patches 2 and 3 with Fixes tag
Andy Shevchenko (7):
stmmac: intel: Fix kernel crash due to wrong error path
stmmac: intel: Fix clock handling on error and remove paths
stmmac: intel: Remove unnecessary loop for PCI BARs
stmmac: intel: Convert to use pci_alloc_irq_vectors() API
stmmac: intel: Eliminate useless conditions and variables
stmmac: intel: Fix indentation to put on one line affected code
stmmac: intel: Place object in the Makefile according to the order
drivers/net/ethernet/stmicro/stmmac/Makefile | 4 +- .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 160 +++++++----------- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +- .../net/ethernet/stmicro/stmmac/stmmac_pci.c | 5 - 4 files changed, 68 insertions(+), 105 deletions(-)
Signature · 1 line
2.26.2