Skip to content

mm/memory_hotplug: Allow to not create firmware memmap entries

David Hildenbrand linux-acpi linux-hyperv linux-mm linux-nvdimm linux-s390 linuxppc-dev lkml nvdimm virtio-dev virtualization xen-devel 2 versions – NAK

Status from this message: Nacked-by: "Eric W. Biederman" <[email protected]>

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 26 repliesNAK
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Don't change the resource name
- Rename the flag to MHP_NO_FIRMWARE_MEMMAP to reflect what it is doing
- Rephrase subjects/descriptions
- Use the flag for dax/kmem

Patches in v2

#Subject and filesSizeRepliesApplied
1/3mm/memory_hotplug: Prepare passing flags to add_memory() and friendsarch/powerpc/platforms/powernv/memtrace.c arch/powerpc/platforms/pseries/hotplug-memory.c drivers/acpi/acpi_memhotplug.c +7 more+18 -160 replies
2/3mm/memory_hotplug: Introduce MHP_NO_FIRMWARE_MEMMAPinclude/linux/memory_hotplug.h mm/memory_hotplug.c+10 -124 replies
3/3device-dax: Add system ram (add_memory()) with MHP_NO_FIRMWARE_MEMMAPdrivers/dax/kmem.c+2 -12 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchWei LiuDave HansenEric W. Biederman
1/3A-b
2/3Nacked-by
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] mm/memory_hotplug: Allow to not create firmware memmap entries

This is the follow up of [1]:
[PATCH v1 0/3] mm/memory_hotplug: Make virtio-mem play nicely with kexec-tools

I realized that this is not only helpful for virtio-mem, but also for dax/kmem - it's a fix for that use case (see patch #3) of persistent memory.

Also, while testing, I discovered that kexec-tools will *not* add dax/kmem memory (anything not directly under the root when parsing /proc/iomem) to the elfcorehdr, so this memory will never get included in a dump. This probably has to be fixed in kexec-tools - virtio-mem will require this as well.

v1 -> v2:
- Don't change the resource name
- Rename the flag to MHP_NO_FIRMWARE_MEMMAP to reflect what it is doing
- Rephrase subjects/descriptions
- Use the flag for dax/kmem

I'll have to rebase virtio-mem on these changes, there will be a resend.

[1] https://lkml.kernel.org/r/[email protected]

David Hildenbrand (3):
mm/memory_hotplug: Prepare passing flags to add_memory() and friends mm/memory_hotplug: Introduce MHP_NO_FIRMWARE_MEMMAP
device-dax: Add system ram (add_memory()) with MHP_NO_FIRMWARE_MEMMAP

 arch/powerpc/platforms/powernv/memtrace.c       |  2 +-
 arch/powerpc/platforms/pseries/hotplug-memory.c |  2 +-
 drivers/acpi/acpi_memhotplug.c                  |  2 +-
 drivers/base/memory.c                           |  2 +-
 drivers/dax/kmem.c                              |  3 ++-
 drivers/hv/hv_balloon.c                         |  2 +-
 drivers/s390/char/sclp_cmd.c                    |  2 +-
 drivers/xen/balloon.c                           |  2 +-
 include/linux/memory_hotplug.h                  | 15 ++++++++++++---
 mm/memory_hotplug.c                             | 14 ++++++++------
 10 files changed, 29 insertions(+), 17 deletions(-)
Signature · 1 line
2.25.3