Skip to content

RFC hw/audio: Make 'soundhw' command line option a QOM interface

Philippe Mathieu-Daudé qemu-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest3 patches 0 repliesNew
  2. v1 RFC1 patch 0 repliesSuperseded

Changes in v2 from the cover letter

- Include Gerd ISA/PCI stub patches to avoid link failure when target does no kselect the bus.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3stubs: add isa_create_simplestubs/Makefile.objs stubs/isa-bus.c+8 -00 replies
2/3stubs: add pci_create_simplestubs/Makefile.objs stubs/pci-bus.c+8 -00 replies
3/3hw/audio: Make 'soundhw' command line option a QOM interfacehw/audio/ac97.c hw/audio/adlib.c hw/audio/cs4231a.c +7 more+178 -1440 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/3R-b T-b
2/3R-b T-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFC PATCH v2 0/3] hw/audio: Make 'soundhw' command line option a QOM interface

After looking at Gerd's "audio: deprecate -soundhw":
https://www.mail-archive.com/[email protected]/msg698818.html
I updated a patch I started some time ago.
It is unfinished due to problem with hda-intel and pcspk. I have some idea how to fix pcspk, but it invasive. I haven't looked at hda-intel yet.
Looking at Gerd series, fixing these issue might be trivial for him, so I send this patch as it, in case it helps.

Since v1:
- Include Gerd ISA/PCI stub patches to avoid link failure when target does no kselect the bus.

Regards,

Phil.

Gerd Hoffmann (2):
stubs: add isa_create_simple
stubs: add pci_create_simple

Philippe Mathieu-Daudé (1):
hw/audio: Make 'soundhw' command line option a QOM interface

 include/hw/audio/soundhw.h |  20 +++-
 hw/audio/ac97.c            |  10 +-
 hw/audio/adlib.c           |  13 ++-
 hw/audio/cs4231a.c         |  13 ++-
 hw/audio/es1370.c          |  10 +-
 hw/audio/gus.c             |  13 ++-
 hw/audio/intel-hda.c       |  13 ++-
 hw/audio/pcspk.c           |  14 ++-
 hw/audio/sb16.c            |  13 ++-
 hw/audio/soundhw.c         | 203 ++++++++++++++++++++-----------------
 stubs/isa-bus.c            |   7 ++
 stubs/pci-bus.c            |   7 ++
 stubs/Makefile.objs        |   2 +
 13 files changed, 194 insertions(+), 144 deletions(-)
 create mode 100644 stubs/isa-bus.c
 create mode 100644 stubs/pci-bus.c
Signature · 1 line
2.21.1