Skip to content

vfio: modify spapr iommu support to use static window sizing

David Christensen dpdk-dev 8 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest1 patch 1 replyApplied
  2. v61 patch 1 replySuperseded
  3. v5 posting 2/20 of 1 patch 0 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v5 posting 1/21 patch7 repliesSuperseded
v41 patch3 repliesSuperseded
v31 patch7 repliesSuperseded
v21 patch0 repliesSuperseded
v12 patches12 repliesSuperseded

Changes in v7 from the cover letter

- No patch changes, fixed email patch description

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/1vfio: modify spapr iommu support to use static window sizinglib/librte_eal/linux/eal_vfio.c+207 -2231 reply

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchAnatoly Burakov
1/1A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [dpdk-dev] [PATCH v7 0/1] vfio: modify spapr iommu support to use static window sizing

The SPAPR v2 IOMMU used on bare-metal PowerNV systems requires that a DMA window be defined before mapping/unmapping memory. The current VFIO code dynamically resizes this DMA window every time a new memory request is made, which requires that all existing memory be unmapped/remapped. While this strategy worked in DPDK 17.11 and earlier where memory was statically allocated during startup, it is potentially dangerous in DPDK 18.11 and later where memory can be allocated during runtime, temporarily invalidating IOVA memory used by hardware.

This new code statically sizes the DMA window at startup, based on the amount of memory installed in the system, avoiding the need to unmap memory during runtime.
---
v7:
- No patch changes, fixed email patch description

v6:
- Fix build error on Linux kernels prior to 4.2.0
- Rebased on 20.11-rc3

v5:
- Modify get_highest_mem_addr to return error, not address
- Add comment regarding sPAPR v1/v2 default window and why it needs to be removed
- Added indent to second line of vfio_spapr_dma_mem_map() definition

v4:
- Move file reading code out of vfio_spapr_window_size_walk()

v3:
- Rebase for 20.08

v2:
- Drop patch to wrap ppc64 code with ifdef's
- Add warning when external memory detected
- Change VA memory size detection to scan memseg list when setting DMA window for IOVA=VA
- Add explicit error message when attempting to map outside the DMA window

David Christensen (1):
vfio: modify spapr iommu support to use static window sizing

 lib/librte_eal/linux/eal_vfio.c | 430 +++++++++++++++-----------------
 1 file changed, 207 insertions(+), 223 deletions(-)
Signature · 1 line
2.18.4