Skip to content

ARM: sunxi: Clean up sun7i-a20-gmac-clk usage

Priit Laes linux-arm-kernel linux-clk linux-devicetree lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest0 of 6 patches 0 repliesNew

Changes in v2 from the cover letter

* Use CLK_OF_DECLARE_DRIVER to make it possible to probe again and set up regmap using platform device probe.
* Clarify the meaning of "legacy" in dwmac-sunxi driver.
* Make sure we don't mess with the RX/TX delay settings when updating clock registers.
* Update devicetree bindings
* Add sun6i-A31 support. (not tested due to lack of hardware)

Patches in v2 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] ARM: sunxi: Clean up sun7i-a20-gmac-clk usage

This serie implements syscon-based regmap access to dwmac-sunxi driver, allowing to deprecate the allwinner,sun7i-a20-gmac-clk clock driver.

In order to register regmap, we firstly need to change existing clock setups (sun7i-a20 and sun6i-a31) from CLK_OF_DECLARE to CLK_OF_DECLARE_DRIVER to allow probing the same driver again via the platform driver framework.

This patchset touches 3 areas:
- sun7i and sun6i CCUs now set up regmap to allow dwmac-sunxi driver to access GMAC clock register.
- dwmac-sunxi can now handle syscon-based clock register to handle its own clock.
- sun7i and sun6i devicetrees are converted to use the new syscon-based access.

After this patchset:
- sun7i-a20 works fully without legacy sunxi clocks (CLK_SUNXI)
- only sun9i-a80 SoC remains as a single sun7i-a20-gmac-clk user.

Please note that sun6i-a31 changes are only build-tested, as I lack the hardware to test this.

Changes since v2:
* Fix broken sun6i-a31 CCU patch.
* Rename series to "Clean up sun7i-a20-gmac-clk usage"

Changes since v1:
* Use CLK_OF_DECLARE_DRIVER to make it possible to probe again and set up regmap using platform device probe.
* Clarify the meaning of "legacy" in dwmac-sunxi driver.
* Make sure we don't mess with the RX/TX delay settings when updating clock registers.
* Update devicetree bindings
* Add sun6i-A31 support. (not tested due to lack of hardware)

Priit Laes (6):
clk: sunxi-ng: a20: Register regmap for sun7i CCU
clk: sunxi-ng: a31: Register regmap for sun6i CCU
net: stmmac: dwmac-sunxi: Implement syscon-based clock handling
dt-bindings: net: sun7i-gmac: Add syscon support
ARM: dts: sun7i: Use syscon-based implementation for gmac
ARM: dts: sun6i: Use syscon-based implementation for gmac

 .../net/allwinner,sun7i-a20-gmac.yaml         |  15 +-
 arch/arm/boot/dts/sun6i-a31.dtsi              |  35 +----
 arch/arm/boot/dts/sun7i-a20.dtsi              |  36 +----
 drivers/clk/sunxi-ng/ccu-sun4i-a10.c          |  62 ++++++++-
 drivers/clk/sunxi-ng/ccu-sun6i-a31.c          |  62 ++++++++-
 .../net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 130 ++++++++++++++++--
 6 files changed, 261 insertions(+), 79 deletions(-)
Signature · 1 line
2.26.2