Skip to content

scsi: enabled reserved commands for LLDDs

Hannes Reinecke linux-scsi 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest15 patches 21 repliesIn review
  2. v818 patches 36 repliesSuperseded
  3. v731 patches 22 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v621 patches16 repliesSuperseded
v522 patches9 repliesSuperseded
v422 patches11 repliesSuperseded
v3 RFC41 patches60 repliesSuperseded

Changes to v8 from the cover letter

- Drop changes to fnic and snic
- Rebase after scsi_get_host_dev() removal
- Rework aacraid to store callback pointer in host_scribble

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15scsi: allocate host devicedrivers/scsi/hosts.c drivers/scsi/scsi_scan.c drivers/scsi/scsi_sysfs.c +2 more+98 -35 replies
2/15scsi: add scsi_{get,put}_internal_cmd() helperdrivers/scsi/scsi_lib.c include/scsi/scsi_device.h+47 -012 replies
3/15scsi: implement reserved command handlingdrivers/scsi/hosts.c drivers/scsi/scsi_lib.c include/scsi/scsi_host.h+32 -22 replies
4/15hpsa: move hpsa_hba_inquiry after scsi_add_host()drivers/scsi/hpsa.c+19 -180 replies
5/15hpsa: use reserved commandsdrivers/scsi/hpsa.c drivers/scsi/hpsa.h+71 -1290 replies
6/15hpsa: use scsi_host_busy_iter() to traverse outstanding commandsdrivers/scsi/hpsa.c+67 -502 replies
7/15hpsa: drop refcount field from CommandListdrivers/scsi/hpsa.c drivers/scsi/hpsa_cmd.h+2 -190 replies
8/15aacraid: return valid status from aac_scsi_cmd()drivers/scsi/aacraid/aachba.c+11 -80 replies
9/15aacraid: don't bother with setting SCp.Statusdrivers/scsi/aacraid/aachba.c+2 -40 replies
10/15aacraid: move scsi_add_host()drivers/scsi/aacraid/linit.c+15 -160 replies
11/15aacraid: move container ID into struct fibdrivers/scsi/aacraid/aachba.c drivers/scsi/aacraid/aacraid.h+16 -90 replies
12/15aacraid: fsa_dev pointer is always validdrivers/scsi/aacraid/aachba.c+36 -430 replies
13/15aacraid: store callback in scsi_cmnd.host_scribbledrivers/scsi/aacraid/aachba.c+6 -60 replies
14/15aacraid: use scsi_get_internal_cmd()drivers/scsi/aacraid/aachba.c drivers/scsi/aacraid/aacraid.h drivers/scsi/aacraid/commctrl.c +4 more+104 -1110 replies
15/15aacraid: use scsi_host_busy_iter() to traverse outstanding commandsdrivers/scsi/aacraid/commsup.c drivers/scsi/aacraid/linit.c+84 -960 replies

Reviews trailers per patch

1 of 15 patches has a Reviewed-by or Acked-by.

PatchDon BraceBart Van AsscheAsutosh Das
1/15
2/15
3/15R-b R-b
4/15T-b
5/15T-b
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v9 thread

Cover letter [PATCHv9 00/15] scsi: enabled reserved commands for LLDDs

Hi all,

quite some drivers use internal commands for various purposes, most commonly sending TMFs or querying the HBA status.
While these commands use the same submission mechanism than normal I/O commands, they will not be counted as outstanding commands, requiring those drivers to implement their own mechanism to figure out outstanding commands.
The block layer already has the concept of 'reserved' tags for precisely this purpose, namely non-I/O tags which live off a separate tag pool. That guarantees that these commands can always be sent, and won't be influenced by tag starvation from the I/O tag pool. This patchset enables the use of reserved tags for the SCSI midlayer by allocating a virtual LUN for the HBA itself which just serves as a resource to allocate valid tags from.

Command allocation currently ignores the hardware queues, as none of the modified drivers is mq-capable.

This patchset is being sent out as a base for the current discussion for enabling reserved commands for the UFS driver; idea is to base those patches on top of this one if we are agree that this is the way forward.

The entire patchset can be found at

git://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
reserved-tags.v9

As usual, comments and reviews are welcome.

Changes to v8:
- Drop changes to fnic and snic
- Rebase after scsi_get_host_dev() removal
- Rework aacraid to store callback pointer in host_scribble

Changes to v7:
- Drop changes to hisi_sas, pm8001, and mv_sas
- Drop patch to introduce REQ_INTERNAL flag
- Include reviews from John Garry

Changes to v6:
- Remove patch to drop gdth
- Rework libsas to use a tag per slow task
- Update hisi_sas, pm8001, and mv_sas

Changes to v5:
- Remove patch for csiostor
- Warn on normal commands in scsi_put_reserved_cmd()
- Fixup aacraid to not only scsi_put_internal_cmd() for reserved commands
- Add 'nr_reserved_cmds' field to host template
- Reshuffle patches

Changes to v4:
- Fixup kbuild warning
- Include reviews from Bart

Changes to v3:
- Kill gdth
- Only convert fnic, snic, hpsa, and aacraid
- Drop command emulation for pseudo host device
- make 'can_queue' exclude the number or reserved tags
- Drop persistent commands proposal
- Sanitize host device handling

Changes to v2:
- Update patches from John Garry
- Use virtual LUN as suggested by Christoph
- Improve SCSI Host device to present a real SCSI device
- Implement 'persistent' commands for AENs
- Convert Megaraid SAS

Changes to v1:
- Make scsi_{get, put}_reserved_cmd() for Scsi host
- Previously we separate scsi_{get, put}_reserved_cmd() for sdev and scsi_host_get_reserved_cmd() for the host
- Fix how Scsi_Host.can_queue is set in the virtio-scsi change
- Drop Scsi_Host.use_reserved_cmd_q
- Drop scsi_is_reserved_cmd()
- Add support in libsas and associated HBA drivers
- Allocate reserved command in slow task
- Switch hisi_sas to use reserved Scsi command
- Reorder the series a little
- Some tidying

Hannes Reinecke (15):
scsi: allocate host device
scsi: add scsi_{get,put}_internal_cmd() helper
scsi: implement reserved command handling
hpsa: move hpsa_hba_inquiry after scsi_add_host()
hpsa: use reserved commands
hpsa: use scsi_host_busy_iter() to traverse outstanding commands
hpsa: drop refcount field from CommandList
aacraid: return valid status from aac_scsi_cmd()
aacraid: don't bother with setting SCp.Status
aacraid: move scsi_add_host()
aacraid: move container ID into struct fib
aacraid: fsa_dev pointer is always valid
aacraid: store callback in scsi_cmnd.host_scribble
aacraid: use scsi_get_internal_cmd()
aacraid: use scsi_host_busy_iter() to traverse outstanding commands

 drivers/scsi/aacraid/aachba.c   | 208 +++++++++---------
 drivers/scsi/aacraid/aacraid.h  |  15 +-
 drivers/scsi/aacraid/commctrl.c |  25 ++-
 drivers/scsi/aacraid/comminit.c |   2 +-
 drivers/scsi/aacraid/commsup.c  | 115 +++++-----
 drivers/scsi/aacraid/dpcsup.c   |   2 +-
 drivers/scsi/aacraid/linit.c    | 170 +++++++--------
 drivers/scsi/hosts.c            |  11 +
 drivers/scsi/hpsa.c             | 364 ++++++++++++++------------------
 drivers/scsi/hpsa.h             |   1 -
 drivers/scsi/hpsa_cmd.h         |  10 -
 drivers/scsi/scsi_lib.c         |  53 ++++-
 drivers/scsi/scsi_scan.c        |  67 +++++-
 drivers/scsi/scsi_sysfs.c       |   3 +-
 include/scsi/scsi_device.h      |   5 +-
 include/scsi/scsi_host.h        |  43 +++-
 16 files changed, 595 insertions(+), 499 deletions(-)
Signature · 1 line
2.29.2