vmdk: Fix zero cluster handling
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | vmdk: Rename VmdkMetaData.valid to new_allocationblock/ | +4 | 1 reply | |
| 2/6 | vmdk: Fix zero cluster allocationblock/ | +7 | 3 replies | |
| 3/6 | vmdk: Fix partial overwrite of zero clusterblock/ | +12 | 1 reply | |
| 4/6 | vmdk: Don't update L2 table for zero write on zero clusterblock/ | +1 | 1 reply | |
| 5/6 | vmdk: Flush only once in vmdk_L2update()block/ | +5 | 1 reply | |
| 6/6 | iotests: vmdk: Enable zeroed_grained=on by defaulttests/ tests/ | +6 | 2 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] vmdk: Fix zero cluster handling
What I was really investigating is why 055 was so slow. I couldn't solve that, but instead I found out that our VMDK code for zero clusters and write_zeroes was completely broken. Apart from segfaults when zero clusters were actually enabled, this caused a compressed backup target to result in a bigger file than uncompressed with VMDK.
This series tries to fix it (with one bonus performance patch).
Kevin Wolf (6):
vmdk: Rename VmdkMetaData.valid to new_allocation
vmdk: Fix zero cluster allocation
vmdk: Fix partial overwrite of zero cluster
vmdk: Don't update L2 table for zero write on zero cluster
vmdk: Flush only once in vmdk_L2update()
iotests: vmdk: Enable zeroed_grained=on by default
block/vmdk.c | 47 +++++++++++++++++++++++++--------------- tests/qemu-iotests/059 | 6 ++--- tests/qemu-iotests/check | 3 +++ 3 files changed, 35 insertions(+), 21 deletions(-)
Signature · 1 line
2.25.3