Skip to content

vmdk: Fix zero cluster handling

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6vmdk: Rename VmdkMetaData.valid to new_allocationblock/vmdk.c+4 -41 reply
2/6vmdk: Fix zero cluster allocationblock/vmdk.c+7 -53 replies
3/6vmdk: Fix partial overwrite of zero clusterblock/vmdk.c+12 -61 reply
4/6vmdk: Don't update L2 table for zero write on zero clusterblock/vmdk.c+1 -11 reply
5/6vmdk: Flush only once in vmdk_L2update()block/vmdk.c+5 -21 reply
6/6iotests: vmdk: Enable zeroed_grained=on by defaulttests/qemu-iotests/059 tests/qemu-iotests/check+6 -32 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] vmdk: Fix zero cluster handling

What I was really investigating is why 055 was so slow. I couldn't solve that, but instead I found out that our VMDK code for zero clusters and write_zeroes was completely broken. Apart from segfaults when zero clusters were actually enabled, this caused a compressed backup target to result in a bigger file than uncompressed with VMDK.

This series tries to fix it (with one bonus performance patch).

Kevin Wolf (6):
vmdk: Rename VmdkMetaData.valid to new_allocation
vmdk: Fix zero cluster allocation
vmdk: Fix partial overwrite of zero cluster
vmdk: Don't update L2 table for zero write on zero cluster
vmdk: Flush only once in vmdk_L2update()
iotests: vmdk: Enable zeroed_grained=on by default

 block/vmdk.c             | 47 +++++++++++++++++++++++++---------------
 tests/qemu-iotests/059   |  6 ++---
 tests/qemu-iotests/check |  3 +++
 3 files changed, 35 insertions(+), 21 deletions(-)
Signature · 1 line
2.25.3