Two bugfixes around prefixes in sets
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | segtree: Fix missing expires value in prefixessrc/ | +1 | 0 replies | |
| 2/4 | segtree: Use expr_clone in get_set_interval_*()src/ | +2 | 0 replies | |
| 3/4 | segtree: Merge get_set_interval_find() and get_set_interval_end()src/ | +16 | 7 replies | |
| 4/4 | segtree: Fix get element command with prefixessrc/ tests/ | +34 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [nft PATCH 0/4] Two bugfixes around prefixes in sets
Patch 1 fixes a pretty obvious typo, leading to prefixes not showing their expiry time.
The remaining patches deal with wrong behaviour of 'get element' command when looking up prefixes. This could have been simple, 'get element' would return the prefix address but prefix length was missing.
While digging through the code, I eventually found out that get_set_interval_find() and get_set_interval_end() didn't respect prefix elements but cared about range elements only.
I am still not entirely sure how the code really works and why everything is needed, but the test case added in patch 4 and some debug output showed that things could be simplified quite a bit. Since this also streamlined adding prefix support, I went ahead with it.
Phil Sutter (4):
segtree: Fix missing expires value in prefixes
segtree: Use expr_clone in get_set_interval_*()
segtree: Merge get_set_interval_find() and get_set_interval_end()
segtree: Fix get element command with prefixes
src/segtree.c | 70 +++++--------------- tests/shell/testcases/sets/0034get_element_0 | 51 +++++++++----- 2 files changed, 51 insertions(+), 70 deletions(-)
Signature · 1 line
2.25.1