Skip to content

Introduce Rocket Lake

Matt Roper intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest22 patches 23 repliesIn review
  2. v123 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Drop the cdclk patch. The bspec was updated since I originally wrote that and now RKL's table is identical to the one we use on TGL and ICL. No RKL-specific driver changes are necessary now.
- Fix a botched mask in the DPCLKA_CFGCR0 clock selection.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22drm/i915/rkl: Add RKL platform info and PCI idsdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_pci.c drivers/gpu/drm/i915/intel_device_info.c +2 more+29 -01 reply
2/22x86/gpu: add RKL stolen memory supportarch/x86/kernel/early-quirks.c+1 -04 replies
3/22drm/i915/rkl: Re-use TGL GuC/HuC firmwaredrivers/gpu/drm/i915/gt/uc/intel_uc_fw.c+3 -00 replies
4/22drm/i915/rkl: Load DMC firmware for Rocket Lakedrivers/gpu/drm/i915/display/intel_csr.c+9 -10 replies
5/22drm/i915/rkl: Add PCH supportdrivers/gpu/drm/i915/intel_pch.c+5 -30 replies
6/22drm/i915/rkl: Update memory bandwidth parametersdrivers/gpu/drm/i915/display/intel_bw.c+9 -11 reply
7/22drm/i915/rkl: Limit number of universal planes to 5drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_sprite.c drivers/gpu/drm/i915/display/intel_sprite.h +3 more+35 -131 reply
8/22drm/i915/rkl: Add power well supportdrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_vdsc.c+186 -34 replies
9/22drm/i915/rkl: Program BW_BUDDY0 registers instead of BW_BUDDY1/2drivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/i915_reg.h+35 -230 replies
10/22drm/i915/rkl: RKL only uses PHY_MISC for PHY's A and Bdrivers/gpu/drm/i915/display/intel_combo_phy.c+17 -133 replies
11/22drm/i915/rkl: Handle new DPCLKA_CFGCR0 layoutdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h+33 -60 replies
12/22drm/i915/rkl: Check proper SDEISR bits for TC1 and TC2 outputsdrivers/gpu/drm/i915/display/intel_dp.c+6 -22 replies
13/22drm/i915/rkl: Setup ports/physdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h+24 -140 replies
14/22drm/i915/rkl: provide port/phy mapping for vbtdrivers/gpu/drm/i915/display/intel_bios.c+51 -213 replies
15/22drm/i915/rkl: Add DDC pin mappingdrivers/gpu/drm/i915/display/intel_hdmi.c+21 -11 reply
16/22drm/i915/rkl: Don't try to access transcoder Ddrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_irq.c+9 -02 replies
17/22drm/i915/rkl: Don't try to read out DSI transcodersdrivers/gpu/drm/i915/display/intel_display.c+1 -11 reply
18/22drm/i915/rkl: Handle comp master/slave relationships for PHYsdrivers/gpu/drm/i915/display/intel_combo_phy.c+23 -21 reply
19/22drm/i915/rkl: Add DPLL4 supportdrivers/gpu/drm/i915/display/intel_dpll_mgr.c+25 -30 replies
20/22drm/i915/rkl: Handle HTIdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dpll_mgr.c drivers/gpu/drm/i915/display/intel_dpll_mgr.h +2 more+58 -40 replies
21/22drm/i915/rkl: Disable PSR2drivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_pci.c +1 more+21 -00 replies
22/22drm/i915/rkl: Add initial workaroundsdrivers/gpu/drm/i915/display/intel_sprite.c drivers/gpu/drm/i915/gt/intel_workarounds.c+59 -340 replies

Reviews trailers per patch

12 of 22 patches have a Reviewed-by or Acked-by.

PatchCaz YokoyamaAnusha SrivatsaAnshuman GuptaVille SyrjäläBorislav Petkov
1/22A-b R-b
2/22R-b A-b
3/22R-b
4/22R-b
5/22
6/22R-b
7/22R-b
8/22R-b
9/22
10/22R-b
11/22
12/22R-b
13/22
14/22R-b
15/22R-b
16/22
17/22
18/22R-b
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [Intel-gfx] [PATCH v2 00/22] Introduce Rocket Lake

Only minor changes since v1, but patchwork got confused by the updates, so sending the whole series again to ensure proper CI testing.

v2 changes:
- Drop the cdclk patch. The bspec was updated since I originally wrote that and now RKL's table is identical to the one we use on TGL and ICL. No RKL-specific driver changes are necessary now.
- Fix a botched mask in the DPCLKA_CFGCR0 clock selection.

See the cover letter from v1 for other details:
https://lists.freedesktop.org/archives/intel-gfx/2020-May/238498.html

Aditya Swarup (1):
drm/i915/rkl: Don't try to read out DSI transcoders

José Roberto de Souza (1):
drm/i915/rkl: Disable PSR2

Lucas De Marchi (1):
drm/i915/rkl: provide port/phy mapping for vbt

Matt Roper (19):
drm/i915/rkl: Add RKL platform info and PCI ids x86/gpu: add RKL stolen memory support
drm/i915/rkl: Re-use TGL GuC/HuC firmware drm/i915/rkl: Load DMC firmware for Rocket Lake drm/i915/rkl: Add PCH support
drm/i915/rkl: Update memory bandwidth parameters drm/i915/rkl: Limit number of universal planes to 5 drm/i915/rkl: Add power well support
drm/i915/rkl: Program BW_BUDDY0 registers instead of BW_BUDDY1/2 drm/i915/rkl: RKL only uses PHY_MISC for PHY's A and B drm/i915/rkl: Handle new DPCLKA_CFGCR0 layout drm/i915/rkl: Check proper SDEISR bits for TC1 and TC2 outputs drm/i915/rkl: Setup ports/phys
drm/i915/rkl: Add DDC pin mapping
drm/i915/rkl: Don't try to access transcoder D drm/i915/rkl: Handle comp master/slave relationships for PHYs drm/i915/rkl: Add DPLL4 support
drm/i915/rkl: Handle HTI
drm/i915/rkl: Add initial workarounds

 arch/x86/kernel/early-quirks.c                |   1 +
 drivers/gpu/drm/i915/display/intel_bios.c     |  72 ++++--
 drivers/gpu/drm/i915/display/intel_bw.c       |  10 +-
 .../gpu/drm/i915/display/intel_combo_phy.c    |  55 +++--
 drivers/gpu/drm/i915/display/intel_csr.c      |  10 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |  18 +-
 drivers/gpu/drm/i915/display/intel_display.c  |  82 +++++--
 .../drm/i915/display/intel_display_power.c    | 229 ++++++++++++++++--
 drivers/gpu/drm/i915/display/intel_dp.c       |   8 +-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |  50 +++-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.h |   1 +
 drivers/gpu/drm/i915/display/intel_hdmi.c     |  22 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |  15 ++
 drivers/gpu/drm/i915/display/intel_sprite.c   |  22 +-
 drivers/gpu/drm/i915/display/intel_sprite.h   |  11 +-
 drivers/gpu/drm/i915/display/intel_vdsc.c     |   4 +-
 drivers/gpu/drm/i915/gt/intel_workarounds.c   |  88 ++++---
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      |   3 +
 drivers/gpu/drm/i915/i915_drv.h               |  13 +
 drivers/gpu/drm/i915/i915_irq.c               |  10 +-
 drivers/gpu/drm/i915/i915_pci.c               |  13 +
 drivers/gpu/drm/i915/i915_reg.h               |  35 ++-
 drivers/gpu/drm/i915/intel_device_info.c      |   6 +-
 drivers/gpu/drm/i915/intel_device_info.h      |   2 +
 drivers/gpu/drm/i915/intel_pch.c              |   8 +-
 include/drm/i915_pciids.h                     |   9 +
 26 files changed, 656 insertions(+), 141 deletions(-)
Signature · 6 lines
2.24.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx