Skip to content

crypto: introduce crypto_shash_tfm_digest()

Eric Biggers ecryptfs keyrings linux-bluetooth linux-crypto linux-mtd linux-nfs linux-sctp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20crypto: hash - introduce crypto_shash_tfm_digest()crypto/shash.c include/crypto/hash.h+35 -00 replies
2/20crypto: arm64/aes-glue - use crypto_shash_tfm_digest()arch/arm64/crypto/aes-glue.c+1 -30 replies
3/20crypto: essiv - use crypto_shash_tfm_digest()crypto/essiv.c+1 -30 replies
4/20crypto: artpec6 - use crypto_shash_tfm_digest()drivers/crypto/axis/artpec6_crypto.c+3 -70 replies
5/20crypto: ccp - use crypto_shash_tfm_digest()drivers/crypto/ccp/ccp-crypto-sha.c+2 -71 reply
6/20crypto: ccree - use crypto_shash_tfm_digest()drivers/crypto/ccree/cc_cipher.c+3 -61 reply
7/20crypto: hisilicon/sec2 - use crypto_shash_tfm_digest()drivers/crypto/hisilicon/sec2/sec_crypto.c+2 -30 replies
8/20crypto: mediatek - use crypto_shash_tfm_digest()drivers/crypto/mediatek/mtk-sha.c+2 -50 replies
9/20crypto: n2 - use crypto_shash_tfm_digest()drivers/crypto/n2_core.c+2 -50 replies
10/20crypto: omap-sham - use crypto_shash_tfm_digest()drivers/crypto/omap-sham.c+4 -160 replies
11/20crypto: s5p-sss - use crypto_shash_tfm_digest()drivers/crypto/s5p-sss.c+6 -331 reply
12/20nfc: s3fwrn5: use crypto_shash_tfm_digest()drivers/nfc/s3fwrn5/firmware.c+1 -90 replies
13/20fscrypt: use crypto_shash_tfm_digest()fs/crypto/fname.c fs/crypto/hkdf.c+2 -110 replies
14/20ecryptfs: use crypto_shash_tfm_digest()fs/ecryptfs/crypto.c+1 -160 replies
15/20nfsd: use crypto_shash_tfm_digest()fs/nfsd/nfs4recover.c+6 -201 reply
16/20ubifs: use crypto_shash_tfm_digest()fs/ubifs/auth.c fs/ubifs/master.c fs/ubifs/replay.c+9 -340 replies
17/20Bluetooth: use crypto_shash_tfm_digest()net/bluetooth/smp.c+1 -50 replies
18/20sctp: use crypto_shash_tfm_digest()net/sctp/auth.c net/sctp/sm_make_chunk.c+10 -230 replies
19/20KEYS: encrypted: use crypto_shash_tfm_digest()security/keys/encrypted-keys/encrypted.c+3 -150 replies
20/20ASoC: cros_ec_codec: use crypto_shash_tfm_digest()sound/soc/codecs/cros_ec_codec.c+1 -80 replies

Reviews trailers per patch

4 of 20 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarcel HoltmannGilad Ben-YossefArd BiesheuvelJ. Bruce FieldsKrzysztof KozlowskiTom Lendacky
SeriesA-b A-b
1/20
2/20
3/20
4/20
5/20A-b
6/20A-b
7/20
8/20
9/20
10/20
11/20A-b
12/20
13/20
14/20
15/20A-b
16/20
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 00/20] crypto: introduce crypto_shash_tfm_digest()

This series introduces a helper function crypto_shash_tfm_digest() which replaces the following common pattern:

	{
		SHASH_DESC_ON_STACK(desc, tfm);
		int err;

		desc->tfm = tfm;

		err = crypto_shash_digest(desc, data, len, out);

		shash_desc_zero(desc);
	}

with:

	err = crypto_shash_tfm_digest(tfm, data, len, out);

Patch 1 introduces this helper function, and patches 2-20 convert all relevant users to use it.

IMO, it would be easiest to take all these patches through the crypto tree. But taking just the "crypto:" ones and then me trying to get the rest merged later via subsystem trees is also an option.

Eric Biggers (20):
crypto: hash - introduce crypto_shash_tfm_digest()
crypto: arm64/aes-glue - use crypto_shash_tfm_digest()
crypto: essiv - use crypto_shash_tfm_digest()
crypto: artpec6 - use crypto_shash_tfm_digest()
crypto: ccp - use crypto_shash_tfm_digest()
crypto: ccree - use crypto_shash_tfm_digest()
crypto: hisilicon/sec2 - use crypto_shash_tfm_digest()
crypto: mediatek - use crypto_shash_tfm_digest()
crypto: n2 - use crypto_shash_tfm_digest()
crypto: omap-sham - use crypto_shash_tfm_digest()
crypto: s5p-sss - use crypto_shash_tfm_digest()
nfc: s3fwrn5: use crypto_shash_tfm_digest()
fscrypt: use crypto_shash_tfm_digest()
ecryptfs: use crypto_shash_tfm_digest()
nfsd: use crypto_shash_tfm_digest()
ubifs: use crypto_shash_tfm_digest()
Bluetooth: use crypto_shash_tfm_digest()
sctp: use crypto_shash_tfm_digest()
KEYS: encrypted: use crypto_shash_tfm_digest()
ASoC: cros_ec_codec: use crypto_shash_tfm_digest()

 arch/arm64/crypto/aes-glue.c               |  4 +--
 crypto/essiv.c                             |  4 +--
 crypto/shash.c                             | 16 +++++++++
 drivers/crypto/axis/artpec6_crypto.c       | 10 ++----
 drivers/crypto/ccp/ccp-crypto-sha.c        |  9 ++---
 drivers/crypto/ccree/cc_cipher.c           |  9 ++---
 drivers/crypto/hisilicon/sec2/sec_crypto.c |  5 ++-
 drivers/crypto/mediatek/mtk-sha.c          |  7 ++--
 drivers/crypto/n2_core.c                   |  7 ++--
 drivers/crypto/omap-sham.c                 | 20 +++--------
 drivers/crypto/s5p-sss.c                   | 39 ++++------------------
 drivers/nfc/s3fwrn5/firmware.c             | 10 +-----
 fs/crypto/fname.c                          |  7 +---
 fs/crypto/hkdf.c                           |  6 +---
 fs/ecryptfs/crypto.c                       | 17 +---------
 fs/nfsd/nfs4recover.c                      | 26 ++++-----------
 fs/ubifs/auth.c                            | 20 ++---------
 fs/ubifs/master.c                          |  9 ++---
 fs/ubifs/replay.c                          | 14 ++------
 include/crypto/hash.h                      | 19 +++++++++++
 net/bluetooth/smp.c                        |  6 +---
 net/sctp/auth.c                            | 10 ++----
 net/sctp/sm_make_chunk.c                   | 23 +++++--------
 security/keys/encrypted-keys/encrypted.c   | 18 ++--------
 sound/soc/codecs/cros_ec_codec.c           |  9 +----
 25 files changed, 95 insertions(+), 229 deletions(-)
Signature · 1 line
2.26.2