Skip to content

vTPM/aarch64 ACPI support

Eric Auger qemu-arm qemu-devel 7 versions – Applied

Status from this message: Applied to target-arm.next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 2 repliesApplied
  2. v63 patches 8 repliesSuperseded
  3. v53 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v45 patches18 repliesSuperseded
v34 patches10 repliesSuperseded
v23 patches17 repliesSuperseded
v12 patches3 repliesSuperseded

Changes in v7 from the cover letter

- Collected Stefan and Igor's R-bs
- Eventually removed Acpi20TPM2 struct
- Updated the reference to the spec v1.2 rev8

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/3acpi: Some build_tpm2() code reshapehw/acpi/aml-build.c include/hw/acpi/acpi-defs.h+32 -370 replies
2/3arm/acpi: Add the TPM2.0 device under the DSDThw/arm/virt-acpi-build.c+34 -00 replies
3/3docs/specs/tpm: ACPI boot now supported for TPM/ARMdocs/specs/tpm.rst+0 -20 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchStefan BergerIgor MammedovArd Biesheuvel
SeriesT-b
1/3R-b T-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/3] vTPM/aarch64 ACPI support

Those patches bring MMIO TPM TIS ACPI support in machvirt.

On ARM, the TPM2 table is added when the TPM TIS sysbus device is dynamically instantiated in machvirt.

Also the TPM2 device object is described in the DSDT.

Many thanks to Ard for his support.

Tested with LUKS partition automatic decryption. Also tested with new bios-tables-test dedicated tests, sent separately.

Best Regards

Eric

This series can be found at:
https://github.com/eauger/qemu/tree/v5.0-tpm-acpi-v7

History:

v6 -> v7:
- Collected Stefan and Igor's R-bs
- Eventually removed Acpi20TPM2 struct
- Updated the reference to the spec v1.2 rev8

v5 -> v6:
- added reference to the spec
- add some comments about LAML and LASA fields which are strangely undocumented in the spec for TPM2.0. So I kept the decision to keep the Acpi20TPM2 struct for documentation purpose.

v4 -> v5:
- Move of build_tpm2() in the generic acpi code was upstreamed but this does not correspond to latest proposed version.
- Rebase on top of edfcb1f21a

v3 -> v4:
- some rework in build_tpm2() as suggested by Igor
- Restored tpm presence check in acpi_dsdt_add_tpm()
- add the doc related patch

v2 -> v3:
- Rebase on top of Stefan's
"acpi: tpm: Do not build TCPA table for TPM 2"
- brings conversion to build_append

v1 -> v2:
- move build_tpm2() in the generic code (Michael)
- collect Stefan's R-b on 3/3

Eric Auger (3):
acpi: Some build_tpm2() code reshape arm/acpi: Add the TPM2.0 device under the DSDT docs/specs/tpm: ACPI boot now supported for TPM/ARM

 docs/specs/tpm.rst          |  2 --
 include/hw/acpi/acpi-defs.h | 18 -------------
 hw/acpi/aml-build.c         | 51 +++++++++++++++++++++++--------------
 hw/arm/virt-acpi-build.c    | 34 +++++++++++++++++++++++++
 4 files changed, 66 insertions(+), 39 deletions(-)
Signature · 1 line
2.20.1