Skip to content

Input: ads7846: pdata cleanups and devm init

Daniel Mack linux-input 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 3 repliesIn review
  2. v33 patches 6 repliesSuperseded
  3. v23 patches 6 repliesSuperseded

Changes in v4 from the cover letter

* Call ads7846_stop() rather than ads7846_disable() in the unbind path to avoid regulator refcount confusion, Thanks to Marco Felsch.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Input: ads7846: Add short-hand for spi->dev in probe() functiondrivers/input/touchscreen/ads7846.c+23 -220 replies
2/3Input: ads7846: Remove custom filter handling functions from pdatadrivers/input/touchscreen/ads7846.c include/linux/spi/ads7846.h+8 -320 replies
3/3Input: ads7846: Switch to devm initializationdrivers/input/touchscreen/ads7846.c+46 -792 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMarco Felsch
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] Input: ads7846: pdata cleanups and devm init

Hi,

This is v4 of the patches to bring devm initialization to the ads7846 driver. I left the gpiod conversion patch out for now as it needs more work, and it's also independent of the other changes.

v3:

* Added a patch to remove custom filter handling from pdata
* Added devm_add_action_or_reset() for regulator state maintaining
* Addressed minor nits pointed out by Marco Felsch

v4:

* Call ads7846_stop() rather than ads7846_disable() in the unbind path to avoid regulator refcount confusion, Thanks to Marco Felsch.

Daniel Mack (3):
Input: ads7846: Add short-hand for spi->dev in probe() function
Input: ads7846: Remove custom filter handling functions from pdata
Input: ads7846: Switch to devm initialization

 drivers/input/touchscreen/ads7846.c | 187 +++++++++++-----------------
 include/linux/spi/ads7846.h         |  15 ---
 2 files changed, 73 insertions(+), 129 deletions(-)
Signature · 1 line
2.26.2