Skip to content

credential: documentation updates for maint

Carlo Marcelo Arenas Belón git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesIn review
  2. v14 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4credential: update description for credential_from_url_gentlycredential.h+2 -20 replies
2/4credential: correct order of parameters for credential_matchcredential.h+2 -20 replies
3/4credential: update gitcredentials documentationDocumentation/gitcredentials.txt+17 -82 replies
4/4credential: document protocol updatesDocumentation/git-credential.txt+21 -131 reply

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchJeff King
1/4R-b
2/4R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] credential: documentation updates for maint

in line with Jonathan's wishlist[1] for a 2.26.3 release, the following changes address minimal code changes related to the latest updates as well to documentation changes that would guide helpers to adjust to the updated credential subsystem.

patches 1 and 2 are unchanged, patch 3 has all suggestions by Peff added and hopefully is ready; patch 4 does integrate all suggestions as well but adds some more changes that I thought were neccesary while rereading it.

I think this time there are no grammatical issues (and a free online checker seems to concur), but as a non native English speaker and ineffective spell checker user, look forward to any suggestions there.

commit message has also been improved based on the feedback received.

not sure how it will look like, but still think that this is the right time to clarify the issue of encoding, if only so that further changes could be coordinated more effectively with helper developers (who seem to be mainly out of tree) so will most likely send an RFC for a 5/4 patch that could be considered for inclusion on a reroll.

[1] https://lore.kernel.org/git/[email protected]/

Carlo Marcelo Arenas Belón (4):
credential: update description for credential_from_url_gently
credential: correct order of parameters for credential_match
credential: update gitcredentials documentation
credential: document protocol updates

 Documentation/git-credential.txt | 34 ++++++++++++++++++++------------
 Documentation/gitcredentials.txt | 25 +++++++++++++++--------
 credential.h                     |  8 ++++----
 3 files changed, 42 insertions(+), 25 deletions(-)
Signature · 1 line
2.26.2.686.gfaf46a9ccd