Skip to content

rockchip: PHY drivers (USB)

Jagan Teki linux-rockchip u-boot 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 1 replyApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7clk: rk3399: Enable/Disable the USB2PHY clkdrivers/clk/rockchip/clk_rk3399.c+12 -00 replies
2/7clk: rk3399: Set empty for TCPHY assigned-clocksdrivers/clk/rockchip/clk_rk3399.c+2 -00 replies
3/7clk: rk3399: Enable/Disable TCPHY clocksdrivers/clk/rockchip/clk_rk3399.c+24 -00 replies
4/7phy: rockchip: Add Rockchip USB2PHY driverdrivers/Makefile drivers/phy/Kconfig drivers/phy/rockchip/Kconfig +2 more+334 -00 replies
5/7arm64: dts: rk3399: Move u2phy into root portarch/arm/dts/rk3399.dtsi+54 -540 replies
6/7phy: rockchip: Add Rockchip USB TypeC PHY driverdrivers/phy/rockchip/Kconfig drivers/phy/rockchip/Makefile drivers/phy/rockchip/phy-rockchip-typec.c+804 -00 replies
7/7usb: dwc3: add dis_del_phy_power_chg_quirkdrivers/usb/dwc3/core.c drivers/usb/dwc3/core.h include/dwc3-uboot.h+8 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] rockchip: PHY drivers (USB)

This is next following series from previous PHY drivers on rockchip [1].

And also tested on top of Frank 'USB 3.0' series [2] from patches 0/9 to 6/9.

With this USB 3.0 Host port seems to detecting USB storage but need more testing on other modes as well.

Log on rock960 and NanoPC-t4:

rock960 => usb start
starting USB...
Bus usb@fe380000: USB EHCI 1.00
Bus usb@fe3c0000: USB EHCI 1.00
Bus dwc3: usb maximum-speed not found
Register 2000140 NbrPorts 2
Starting the controller
USB XHCI 1.10
scanning bus usb@fe380000 for devices... 1 USB Device(s) found scanning bus usb@fe3c0000 for devices... 1 USB Device(s) found scanning bus dwc3 for devices... 2 USB Device(s) found
scanning usb for storage devices... 1 Storage Device(s) found
rock960 => usb tree
USB device tree:
1 Hub (480 Mb/s, 0mA)
u-boot EHCI Host Controller

1 Hub (480 Mb/s, 0mA)
u-boot EHCI Host Controller

1 Hub (5 Gb/s, 0mA)
| U-Boot XHCI Host Controller
|
+-2 Mass Storage (480 Mb/s, 200mA)
Generic Mass Storage 789CDB36

=> usb start
starting USB...
Bus usb@fe380000: USB EHCI 1.00
Bus usb@fe3c0000: USB EHCI 1.00
Bus dwc3: usb maximum-speed not found
dwc3_of_parse: In
Register 2000140 NbrPorts 2
Starting the controller
USB XHCI 1.10
Bus dwc3: usb maximum-speed not found
dwc3_of_parse: In
Register 2000140 NbrPorts 2
Starting the controller
USB XHCI 1.10
scanning bus usb@fe380000 for devices... 1 USB Device(s) found scanning bus usb@fe3c0000 for devices... 1 USB Device(s) found scanning bus dwc3 for devices... 1 USB Device(s) found scanning bus dwc3 for devices... 2 USB Device(s) found
scanning usb for storage devices... 1 Storage Device(s) found
=> usb tree
USB device tree:
1 Hub (480 Mb/s, 0mA)
u-boot EHCI Host Controller

1 Hub (480 Mb/s, 0mA)
u-boot EHCI Host Controller

1 Hub (5 Gb/s, 0mA)
U-Boot XHCI Host Controller

1 Hub (5 Gb/s, 0mA)
| U-Boot XHCI Host Controller
|
+-2 Mass Storage (480 Mb/s, 200mA)
Generic Mass Storage 789CDB36

[2] https://patchwork.ozlabs.org/project/uboot/cover/20200430021620.25772-1-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org/
[1] https://patchwork.ozlabs.org/project/uboot/cover/20200430214529.18887-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org/

Any inputs?
Jagan.

Jagan Teki (7):
clk: rk3399: Enable/Disable the USB2PHY clk
clk: rk3399: Set empty for TCPHY assigned-clocks
clk: rk3399: Enable/Disable TCPHY clocks
phy: rockchip: Add Rockchip USB2PHY driver
arm64: dts: rk3399: Move u2phy into root port
phy: rockchip: Add Rockchip USB TypeC PHY driver
usb: dwc3: add dis_del_phy_power_chg_quirk

 arch/arm/dts/rk3399.dtsi                      | 108 +--
 drivers/Makefile                              |   1 +
 drivers/clk/rockchip/clk_rk3399.c             |  38 +
 drivers/phy/Kconfig                           |   1 +
 drivers/phy/rockchip/Kconfig                  |  21 +
 drivers/phy/rockchip/Makefile                 |   7 +
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 312 +++++++
 drivers/phy/rockchip/phy-rockchip-typec.c     | 796 ++++++++++++++++++
 drivers/usb/dwc3/core.c                       |   6 +
 drivers/usb/dwc3/core.h                       |   1 +
 include/dwc3-uboot.h                          |   1 +
 11 files changed, 1238 insertions(+), 54 deletions(-)
 create mode 100644 drivers/phy/rockchip/Kconfig
 create mode 100644 drivers/phy/rockchip/Makefile
 create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-usb2.c
 create mode 100644 drivers/phy/rockchip/phy-rockchip-typec.c
Signature · 1 line
2.17.1