Skip to content

Fix blkparse and iowatcher for kernels >= 4.14

Jan Kara linux-block 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3blkparse: Handle cgroup informationblkparse.c blkparse_fmt.c blktrace_api.h +2 more+58 -150 replies
2/3iowatcher: Use blktrace_api.hiowatcher/blkparse.c+1 -1030 replies
3/3iowatcher: Handle cgroup informationiowatcher/blkparse.c+22 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Fix blkparse and iowatcher for kernels >= 4.14

I was investigating a performance issue with BFQ IO scheduler and I was pondering why I'm not seeing informational messages from BFQ. After quite some debugging I have found out that commit 35fe6d763229 "block: use standard blktrace API to output cgroup info for debug notes" broke standard blktrace API - namely the informational messages logged by bfq_log_bfqq() are no longer displayed by blkparse(8) tool. This is because these messages have now __BLK_TA_CGROUP bit set and that breaks flags checking in blkparse(1) and iowatcher(1). This series fixes both tools to be able to cope with events with __BLK_TA_CGROUP flag set.

Honza