Skip to content

Pass down "--quiet" to "gc --auto"

Junio C Hamano git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2auto-gc: extract a reusable helper from "git fetch"builtin/fetch.c run-command.c run-command.h+20 -80 replies
2/2auto-gc: pass --quiet down from am, commit, merge and rebasebuiltin/am.c builtin/commit.c builtin/merge.c +1 more+4 -81 reply
2/2auto-gc: pass --quiet down from am, commit, merge and rebasebuiltin/am.c builtin/commit.c builtin/merge.c +1 more+4 -82 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchTaylor Blau
1/2
2/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Pass down "--quiet" to "gc --auto"

A handful commands take "--quiet" from their command line, but forgets to pass it down, when they trigger an auto gc, to the "git gc --auto" they internally invoke.

Back in 1991006c (fetch: convert argv_gc_auto to struct argv_array, 2014-08-16), we patched "git fetch" but seems to have forgotten doing the same for "git merge". Since then, rewrite of "git am" and "git rebase" in C spread the same problem into two more codepaths.

Let's clean them up once and for all.

Junio C Hamano (2):
run_auto_gc(): extract a reusable helper
auto-gc: pass --quiet down from am, commit, merge and rebase

 builtin/am.c     |  3 +--
 builtin/commit.c |  3 +--
 builtin/fetch.c  | 10 ++--------
 builtin/merge.c  |  3 +--
 builtin/rebase.c |  3 +--
 run-command.c    | 13 +++++++++++++
 run-command.h    |  5 +++++
 7 files changed, 24 insertions(+), 16 deletions(-)
Signature · 1 line
2.26.2-561-g07d8ea56f2