Skip to content

mirror: Make sure that source and target size match

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 15 repliesIn review
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Added patch 1 to fix a test that used different source/target size

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4iotests/109: Don't mirror with mismatched sizetests/qemu-iotests/109 tests/qemu-iotests/109.out tests/qemu-iotests/common.filter+41 -484 replies
2/4iotests/229: Use blkdebug to inject an errortests/qemu-iotests/229 tests/qemu-iotests/229.out+14 -73 replies
3/4mirror: Make sure that source and target size matchblock/mirror.c+12 -95 replies
4/4iotests: Mirror with different source/target sizetests/qemu-iotests/041 tests/qemu-iotests/041.out+47 -23 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchEric BlakeMax ReitzVladimir Sementsov-Ogievskiy
1/4R-b R-b
2/4R-b R-b R-b
3/4R-b R-b R-b
4/4R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] mirror: Make sure that source and target size match

Same thing as the recent fix for backup, except that mirror already forbids resizing during the job. So what remains is checking that the sizes match at the start of the job.

v2:
- Added patch 1 to fix a test that used different source/target size

Kevin Wolf (4):
iotests/109: Don't mirror with mismatched size iotests/229: Use blkdebug to inject an error
mirror: Make sure that source and target size match
iotests: Mirror with different source/target size

 block/mirror.c                   | 21 +++++----
 tests/qemu-iotests/041           | 45 +++++++++++++++++++
 tests/qemu-iotests/041.out       |  4 +-
 tests/qemu-iotests/109           | 10 ++---
 tests/qemu-iotests/109.out       | 74 +++++++++++++-------------------
 tests/qemu-iotests/229           | 15 +++++--
 tests/qemu-iotests/229.out       |  6 +--
 tests/qemu-iotests/common.filter |  5 +++
 8 files changed, 114 insertions(+), 66 deletions(-)
Signature · 1 line
2.25.3