Skip to content

exec: Shear 'exec/ram_addr.h' and make NVMe device target-agnostic

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10exec: Rename qemu_ram_writeback() as qemu_ram_msync()exec.c hw/block/nvme.c include/exec/ram_addr.h +1 more+5 -61 reply
2/10exec/ramblock: Add missing 'qemu/rcu.h' includeinclude/exec/ramblock.h+1 -01 reply
3/10exec: Move tb_invalidate_phys_range() to 'exec/exec-all.h'include/exec/exec-all.h include/exec/ram_addr.h+8 -80 replies
4/10exec/memory-internal: Check CONFIG_SOFTMMU instead of CONFIG_USER_ONLYinclude/exec/memory-internal.h+1 -11 reply
5/10exec: Move qemu_minrampagesize/qemu_maxrampagesize to 'qemu-common.h'hw/ppc/spapr_caps.c hw/s390x/s390-virtio-ccw.c hw/vfio/spapr.c +2 more+13 -53 replies
6/10exec: Move ramblock_recv_bitmap_offset() to migration/ram.cinclude/exec/ram_addr.h migration/ram.c+8 -82 replies
7/10exec: Move all RAMBlock functions to 'exec/ramblock.h'accel/tcg/translate-all.c hw/block/nvme.c hw/s390x/s390-stattrib-kvm.c +17 more+145 -1393 replies
8/10hw/block: Let the NVMe emulated device be target-agnostichw/block/Makefile.objs+1 -12 replies
9/10exec: Update coding style to make checkpatch.pl happyinclude/exec/ram_addr.h+15 -91 reply
10/10exec: Move cpu_physical_memory_* functions to 'exec/memory-internal.h'accel/tcg/cputlb.c hw/ppc/spapr.c hw/ppc/spapr_pci.c +3 more+305 -3072 replies

Reviews trailers per patch

9 of 10 patches have a Reviewed-by or Acked-by.

PatchJuan QuintelaCornelia HuckDavid Gibson
1/10R-b
2/10R-b
3/10
4/10R-b
5/10R-b A-b A-b
6/10R-b
7/10R-b A-b A-b
8/10R-b
9/10R-b
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/10] exec: Shear 'exec/ram_addr.h' and make NVMe device target-agnostic

Stefan suggested to make qemu_ram_writeback() target agnostic, Paolo to add memory_region_msync(), and Peter to remove "exec/ram_addr.h" [*].

I let a single function in this file, cpu_physical_memory_sync_dirty_bitmap(), to let the maintainer have the pleasure to remove this header definitively himself :)

Based-on: <[email protected]> "Move Xen accelerator code under accel/xen/"
https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg01722.html

[*] https://www.mail-archive.com/[email protected]/msg66242.html

Philippe Mathieu-Daudé (10):
exec: Rename qemu_ram_writeback() as qemu_ram_msync() exec/ramblock: Add missing 'qemu/rcu.h' include
exec: Move tb_invalidate_phys_range() to 'exec/exec-all.h' exec/memory-internal: Check CONFIG_SOFTMMU instead of CONFIG_USER_ONLY
exec: Move qemu_minrampagesize/qemu_maxrampagesize to 'qemu-common.h'
exec: Move ramblock_recv_bitmap_offset() to migration/ram.c
exec: Move all RAMBlock functions to 'exec/ramblock.h' hw/block: Let the NVMe emulated device be target-agnostic
exec: Update coding style to make checkpatch.pl happy
exec: Move cpu_physical_memory_* functions to 'exec/memory-internal.h'

 include/exec/cpu-common.h      |  24 --
 include/exec/exec-all.h        |  14 +-
 include/exec/memory-internal.h | 307 +++++++++++++++++++++++-
 include/exec/ram_addr.h        | 415 +--------------------------------
 include/exec/ramblock.h        | 135 +++++++++++
 include/qemu-common.h          |  10 +
 migration/migration.h          |   1 +
 accel/tcg/cputlb.c             |   1 -
 accel/tcg/translate-all.c      |   2 -
 exec.c                         |   2 +-
 hw/block/nvme.c                |   5 +-
 hw/ppc/spapr.c                 |   1 -
 hw/ppc/spapr_caps.c            |   2 +-
 hw/ppc/spapr_pci.c             |   1 -
 hw/s390x/s390-stattrib-kvm.c   |   1 -
 hw/s390x/s390-stattrib.c       |   1 -
 hw/s390x/s390-virtio-ccw.c     |   2 +-
 hw/vfio/spapr.c                |   2 +-
 hw/virtio/vhost-user.c         |   1 +
 hw/virtio/vhost.c              |   1 +
 hw/virtio/virtio-balloon.c     |   1 +
 memory.c                       |   4 +-
 migration/migration.c          |   1 +
 migration/postcopy-ram.c       |   1 +
 migration/ram.c                |   8 +
 migration/savevm.c             |   1 +
 stubs/ram-block.c              |   2 +-
 target/ppc/kvm.c               |   1 -
 target/s390x/kvm.c             |   1 -
 util/vfio-helpers.c            |   2 +-
 hw/block/Makefile.objs         |   2 +-
 31 files changed, 485 insertions(+), 467 deletions(-)
Signature · 1 line
2.21.3