Skip to content

common: Further reduce the size of common.h

Tom Rini u-boot 2 versions – New

Get series with b4
b4 am 20200515211343.GM4794@bill-the-cat

Versions newest first · linked by author and title

  1. v3 Latest22 patches 0 repliesNew
  2. v21 of 22 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22common: Drop uuid.h from common header+0 -00 replies
2/22flash: Tidy up coding style for flash functions+0 -00 replies
3/22common: Drop flash.h from common header+0 -00 replies
4/22arm: Don't include common.h in header files+0 -00 replies
5/22common: Drop net.h from common header+0 -00 replies
6/22part: Drop disk_partition_t typedef+0 -00 replies
7/22common: Drop part.h from common header+0 -00 replies
8/22bootstage: Use BOOTSTAGE instead of BOOTSTATE+0 -00 replies
9/22common: Drop bootstage.h from common header+0 -00 replies
10/22common: Drop image.h from common header+0 -00 replies
11/22common: Drop init.h from common header+0 -00 replies
12/22command: Remove the cmd_tbl_t typedef+0 -00 replies
13/22Fix some checkpatch warnings in calls to debug()+0 -00 replies
14/22common: Drop log.h from common header+0 -00 replies
15/22common: Drop asm/ptrace.h from common header+0 -00 replies
16/22common: Drop asm_offsets.h from common header+0 -00 replies
17/22common: Drop linux/bug.h from common header+0 -00 replies
18/22common: Drop linux/stringify.h from common header+0 -00 replies
19/22Fix some checkpatch warnings in calls to udelay()+0 -00 replies
20/22common: Drop linux/delay.h from common header+0 -00 replies
21/22Use __ASSEMBLY__ as the assembly macros+0 -00 replies
21/22Use __ASSEMBLY__ as the assembly macros+0 -00 replies
22/22common: Drop linux/bitops.h from common header+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/22] common: Further reduce the size of common.h
Quoted 30 lines · Simon Glass

Hi Tom,

Quoted 19 lines · Simon Glass

This is yet another series to remove the contents of common.h so that individual files include the headers they need.

With this series there are only 14 includes left.

In order to get this far the commits include a number of small clean-ups:

- Fixing code style like 'udelay (2)' to 'udelay(1)
- Dropping typedefs so that forward struct declarations can be used
- Actually adding common.h in a few files where it is missing (thus causing inconsistent blk.h config in EFI, for example)

Unfortunately removing a header from common.h does not always just affect the files that rely on that header. For example, removing net.h from common.h created problems since net.h itself includes a lots of headers. Rather than blindly add net.h to each of those files, I chose to add what those files actually needed.

Quoted 7 lines

Changes in v3:
- Update imxrt1020-evk, etc.
- Update stm32mp15_optee, etc.
- Update vocore2, etc.
- Rebase to master
- Addition fix for xilinx_zynqmp_mini etc.

Quoted 1 line

Just wondering about the fate of this series?

Working my way back to it again, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200515/d6b59f0b/attachment.sig>