Skip to content

nouveau/hmm: add support for mapping large pages

Ralph Campbell linux-kselftest linux-mm linux-rdma lkml nouveau 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6nouveau/hmm: map pages after migrationdrivers/gpu/drm/nouveau/nouveau_dmem.c drivers/gpu/drm/nouveau/nouveau_dmem.h drivers/gpu/drm/nouveau/nouveau_svm.c +1 more+95 -170 replies
2/6nouveau: make nvkm_vmm_ctor() and nvkm_mmu_ptp_get() staticdrivers/gpu/drm/nouveau/nvkm/subdev/mmu/base.c drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h+3 -60 replies
3/6nouveau/hmm: fault one page at a timedrivers/gpu/drm/nouveau/nouveau_svm.c+65 -1330 replies
4/6mm/hmm: add output flag for compound page mappinginclude/linux/hmm.h mm/hmm.c+10 -44 replies
5/6nouveau/hmm: support mapping large sysmem pagesdrivers/gpu/drm/nouveau/nouveau_svm.c drivers/gpu/drm/nouveau/nvkm/subdev/mmu/base.c drivers/gpu/drm/nouveau/nvkm/subdev/mmu/priv.h +2 more+66 -240 replies
6/6hmm: add tests for HMM_PFN_COMPOUND flaglib/test_hmm.c lib/test_hmm_uapi.h tools/testing/selftests/vm/hmm-tests.c+80 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] nouveau/hmm: add support for mapping large pages

hmm_range_fault() returns an array of page frame numbers and flags for how the pages are mapped in the requested process' page tables. The PFN can be used to get the struct page with hmm_pfn_to_page() and the page size order can be determined with compound_order(page) but if the page is larger than order 0 (PAGE_SIZE), there is no indication that the page is mapped using a larger page size. To be fully general, hmm_range_fault() would need to return the mapping size to handle cases like a 1GB compound page being mapped with 2MB PMD entries. However, the most common case is the mapping size the same as the underlying compound page size.
This series adds a new output flag to indicate this so that callers know it is safe to use a large device page table mapping if one is available. Nouveau and the HMM tests are updated to use the new flag.

Note that this series depends on a patch queued in Ben Skeggs' nouveau tree ("nouveau/hmm: map pages after migration") and the patches queued in Jason's HMM tree.
There is also a patch outstanding ("nouveau/hmm: fix nouveau_dmem_chunk allocations") that is independent of the above and could be applied before or after.

Ralph Campbell (6):
nouveau/hmm: map pages after migration
nouveau: make nvkm_vmm_ctor() and nvkm_mmu_ptp_get() static nouveau/hmm: fault one page at a time
mm/hmm: add output flag for compound page mapping nouveau/hmm: support mapping large sysmem pages
hmm: add tests for HMM_PFN_COMPOUND flag

 drivers/gpu/drm/nouveau/nouveau_dmem.c        |  46 ++-
 drivers/gpu/drm/nouveau/nouveau_dmem.h        |   2 +
 drivers/gpu/drm/nouveau/nouveau_svm.c         | 288 +++++++++---------
 drivers/gpu/drm/nouveau/nouveau_svm.h         |   5 +
 .../gpu/drm/nouveau/nvkm/subdev/mmu/base.c    |   6 +-
 .../gpu/drm/nouveau/nvkm/subdev/mmu/priv.h    |   2 +
 drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c |  12 +-
 drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h |   3 -
 .../drm/nouveau/nvkm/subdev/mmu/vmmgp100.c    |  29 +-
 include/linux/hmm.h                           |   4 +-
 lib/test_hmm.c                                |   2 +
 lib/test_hmm_uapi.h                           |   2 +
 mm/hmm.c                                      |  10 +-
 tools/testing/selftests/vm/hmm-tests.c        |  76 +++++
 14 files changed, 311 insertions(+), 176 deletions(-)
Signature · 1 line
2.20.1