Skip to content

Critical: Unbreak nfnl_osf tool

Phil Sutter netfilter-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nfnl_osf: Fix broken conversion to nfnl_query()utils/nfnl_osf.c+4 -20 replies
2/2nfnl_osf: Improve error handlingutils/nfnl_osf.c+10 -51 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [iptables PATCH v2 0/2] Critical: Unbreak nfnl_osf tool

No changes in patch 1, it is still the right fix for the problem and restores original behaviour.

Patch 2 changed according to feedback:

- Elaborate on why there are duplicates in pf.os in the first place.

- Ignore ENOENT when deleting. Since the code ignores EEXIST when creating, reporting this was asymmetrical behaviour.

- Fix for ugly error message when user didn't specify '-f' option.

Phil Sutter (2):
nfnl_osf: Fix broken conversion to nfnl_query()
nfnl_osf: Improve error handling

 utils/nfnl_osf.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)
Signature · 1 line
2.26.2