aio-posix: fix fdmon-io_uring memory leak
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | aio-posix: don't duplicate fd handler deletion in fdmon_io_uring_destroy()util/ util/ | +11 | 1 reply | |
| 2/2 | aio-posix: disable fdmon-io_uring when GSource is usedinclude/ util/ util/ +1 more | +20 | 1 reply |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Oleksandr Natalenko |
|---|---|
| 1/2 | T-b |
| 2/2 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] aio-posix: fix fdmon-io_uring memory leak
This bug was introduced in QEMU 5.0 and causes guests to slow down because AioHandlers are not freed when the fdmon-io_uring file descriptor monitoring implementation is used by the main loop thread's glib event loop. This issue does not apply to IOThread usage of fdmon-io_uring.
In practice few distros build with io_uring support enabled at the moment, so the number of affected users is likely to be small. The fix is still suitable for a stable release though.
https://bugs.launchpad.net/qemu/+bug/1877716
https://bugs.launchpad.net/qemu/+bug/1873032
Stefan Hajnoczi (2):
aio-posix: don't duplicate fd handler deletion in
fdmon_io_uring_destroy()
aio-posix: disable fdmon-io_uring when GSource is used
include/block/aio.h | 3 +++ util/aio-posix.c | 13 +++++++++++++ util/aio-win32.c | 4 ++++ util/async.c | 1 + util/fdmon-io_uring.c | 13 ++++++++++--- 5 files changed, 31 insertions(+), 3 deletions(-)
Signature · 1 line
2.25.3