Skip to content

Possible NFSD patches for v5.8

Chuck Lever linux-nfs linux-rdma 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest33 patches 1 replyIn review
  2. v332 patches 0 repliesSuperseded
  3. v229 patches 10 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v115 patches0 repliesSuperseded

Changes in v4 from the cover letter

* Rebased on v5.7-rc6 + ("SUNRPC: Split the xdr_buf event class")

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/33SUNRPC: Split the xdr_buf event classinclude/trace/events/sunrpc.h net/sunrpc/clnt.c net/sunrpc/svc_xprt.c +1 more+71 -520 replies
2/33SUNRPC: Move xpt_mutex into socket xpo_sendto methodsinclude/linux/sunrpc/svc_xprt.h net/sunrpc/svc_xprt.c net/sunrpc/svcsock.c +3 more+64 -350 replies
3/33svcrdma: Clean up the tracing for rw_ctx_init errorsinclude/trace/events/rpcrdma.h net/sunrpc/xprtrdma/svc_rdma_rw.c+43 -250 replies
4/33svcrdma: Clean up handling of get_rw_ctx errorsinclude/trace/events/rpcrdma.h net/sunrpc/xprtrdma/svc_rdma_rw.c+36 -160 replies
5/33svcrdma: Trace page overruns when constructing RDMA Readsinclude/trace/events/rpcrdma.h net/sunrpc/xprtrdma/svc_rdma_rw.c+29 -10 replies
6/33svcrdma: trace undersized Write chunksinclude/trace/events/rpcrdma.h net/sunrpc/xprtrdma/svc_rdma_rw.c+34 -50 replies
7/33svcrdma: Fix backchannel return codeinclude/linux/sunrpc/svc_rdma.h net/sunrpc/xprtrdma/svc_rdma_backchannel.c net/sunrpc/xprtrdma/svc_rdma_recvfrom.c+17 -370 replies
8/33svcrdma: Remove backchannel dprintk call sitesnet/sunrpc/xprtrdma/svc_rdma_backchannel.c+5 -430 replies
9/33svcrdma: Rename tracepoints that record header decoding errorsinclude/trace/events/rpcrdma.h net/sunrpc/xprtrdma/svc_rdma_recvfrom.c+8 -70 replies
10/33svcrdma: Remove the SVCRDMA_DEBUG macroinclude/linux/sunrpc/svc_rdma.h+0 -10 replies
11/33svcrdma: Displayed remote IP address should match stored addressnet/sunrpc/xprtrdma/svc_rdma_transport.c+6 -10 replies
12/33svcrdma: Add tracepoints to report ->xpo_accept failuresinclude/trace/events/rpcrdma.h net/sunrpc/xprtrdma/svc_rdma_transport.c+48 -170 replies
13/33SUNRPC: Remove kernel memory address from svc_xprt tracepointsinclude/trace/events/sunrpc.h+7 -200 replies
14/33SUNRPC: Tracepoint to record errors in svc_xpo_create()include/trace/events/sunrpc.h net/sunrpc/svc_xprt.c+35 -10 replies
15/33SUNRPC: Trace a few more generic svc_xprt eventsinclude/trace/events/rpcrdma.h include/trace/events/sunrpc.h net/sunrpc/svc_xprt.c +2 more+45 -810 replies
16/33SUNRPC: Remove "#include <trace/events/skb.h>"net/sunrpc/svcsock.c+0 -10 replies
17/33SUNRPC: Add more svcsock tracepointsinclude/trace/events/sunrpc.h net/sunrpc/svcsock.c+107 -200 replies
18/33SUNRPC: Replace dprintk call sites in TCP state change calloutsinclude/trace/events/sunrpc.h net/sunrpc/svcsock.c+73 -290 replies
19/33SUNRPC: Trace server-side rpcbind registration eventsinclude/trace/events/sunrpc.h net/sunrpc/svc.c+84 -150 replies
20/33SUNRPC: Rename svc_sock::sk_recleninclude/linux/sunrpc/svcsock.h net/sunrpc/svcsock.c+6 -60 replies
21/33SUNRPC: Restructure svc_tcp_recv_record()include/trace/events/sunrpc.h net/sunrpc/svcsock.c+49 -260 replies
22/33SUNRPC: Replace dprintk() call sites in TCP receive pathinclude/trace/events/sunrpc.h net/sunrpc/svcsock.c+3 -140 replies
23/33SUNRPC: Refactor recvfrom path dealing with incomplete TCP receivesinclude/trace/events/sunrpc.h net/sunrpc/svcsock.c+50 -200 replies
24/33SUNRPC: Clean up svc_release_skb() functionsnet/sunrpc/svcsock.c+15 -80 replies
25/33SUNRPC: Refactor svc_recvfrom()include/linux/sunrpc/svc.h net/sunrpc/svcsock.c+69 -410 replies
26/33SUNRPC: Restructure svc_udp_recvfrom()include/trace/events/sunrpc.h net/sunrpc/svcsock.c+37 -250 replies
27/33SUNRPC: svc_show_status() macro should have enum definitionsinclude/trace/events/sunrpc.h+11 -00 replies
28/33NFSD: Add tracepoints to NFSD's duplicate reply cachefs/nfsd/nfscache.c fs/nfsd/trace.h+94 -220 replies
29/33NFSD: Add tracepoints to the NFSD state management codefs/nfsd/nfs4state.c fs/nfsd/state.h fs/nfsd/trace.h+152 -400 replies
30/33NFSD: Add tracepoints for monitoring NFSD callbacksfs/nfsd/nfs4callback.c fs/nfsd/nfs4state.c fs/nfsd/trace.h+177 -190 replies
31/33SUNRPC: Clean up request deferral tracepointsinclude/trace/events/sunrpc.h net/sunrpc/svc_xprt.c+14 -90 replies
32/33NFSD: Squash an annoying compiler warningfs/nfsd/nfs4state.c+2 -30 replies
33/33NFSD: Fix improperly-formatted Doxygen commentsfs/nfsd/nfs4proc.c fs/nfsd/nfsctl.c+16 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 00/33] Possible NFSD patches for v5.8

Hi Bruce-

To address merge conflicts with Anna's tree, I've rebased this series on v5.7-rc6 plus ("SUNRPC: Split the xdr_buf event class"). Only two commits were changed by this rebase:

SUNRPC: Move xpt_mutex into socket xpo_sendto methods
SUNRPC: Add more svcsock tracepoints

Feel free to make use of this version, or ignore it. :-)

Available to view:
https://git.linux-nfs.org/?p=cel/cel-2.6.git;a=shortlog;h=refs/heads/nfsd-5.8

Pull from this topic branch:
git://git.linux-nfs.org/projects/cel/cel-2.6.git nfsd-5.8

Highlights of this series:
* Remove serialization of sending RPC/RDMA Replies
* Convert the TCP socket send path to use xdr_buf::bvecs (pre-requisite for RPC-on-TLS)
* Fix svcrdma backchannel sendto return code
* Convert a number of dprintk call sites to use tracepoints
* Fix the "suggest braces around empty body in an 'else' statement" warning

Changes since v3:
* Rebased on v5.7-rc6 + ("SUNRPC: Split the xdr_buf event class")

Changes since v2:
* Rebased on v5.7-rc6
* Fixed a logic error that left XPT_DATA unset on return from svc_tcp_recvfrom()
* Broke down "SUNRPC: Refactor svc_recvfrom()" to separate clean ups from logic changes
* Some superfluous clean-ups have been redacted
* Add separate tracepoints for error cases (eg, tcp_recv and tcp_recv_err)

Changes since v1:
* Rebased on v5.7-rc5+
* Re-organized the series so changes interesting to linux-rdma appear together
* Addressed sparse warnings found by the kbuild test robot
* Included an additional minor clean-up: removal of the unused SVCRDMA_DEBUG macro
* Clarified several patch descriptions

---

Chuck Lever (33):
SUNRPC: Split the xdr_buf event class
SUNRPC: Move xpt_mutex into socket xpo_sendto methods
svcrdma: Clean up the tracing for rw_ctx_init errors
svcrdma: Clean up handling of get_rw_ctx errors
svcrdma: Trace page overruns when constructing RDMA Reads
svcrdma: trace undersized Write chunks
svcrdma: Fix backchannel return code
svcrdma: Remove backchannel dprintk call sites
svcrdma: Rename tracepoints that record header decoding errors
svcrdma: Remove the SVCRDMA_DEBUG macro
svcrdma: Displayed remote IP address should match stored address
svcrdma: Add tracepoints to report ->xpo_accept failures
SUNRPC: Remove kernel memory address from svc_xprt tracepoints
SUNRPC: Tracepoint to record errors in svc_xpo_create()
SUNRPC: Trace a few more generic svc_xprt events
SUNRPC: Remove "#include <trace/events/skb.h>"
SUNRPC: Add more svcsock tracepoints
SUNRPC: Replace dprintk call sites in TCP state change callouts
SUNRPC: Trace server-side rpcbind registration events
SUNRPC: Rename svc_sock::sk_reclen
SUNRPC: Restructure svc_tcp_recv_record()
SUNRPC: Replace dprintk() call sites in TCP receive path
SUNRPC: Refactor recvfrom path dealing with incomplete TCP receives
SUNRPC: Clean up svc_release_skb() functions
SUNRPC: Refactor svc_recvfrom()
SUNRPC: Restructure svc_udp_recvfrom()
SUNRPC: svc_show_status() macro should have enum definitions
NFSD: Add tracepoints to NFSD's duplicate reply cache
NFSD: Add tracepoints to the NFSD state management code
NFSD: Add tracepoints for monitoring NFSD callbacks
SUNRPC: Clean up request deferral tracepoints
NFSD: Squash an annoying compiler warning
NFSD: Fix improperly-formatted Doxygen comments

 fs/nfsd/nfs4callback.c                     |  37 +-
 fs/nfsd/nfs4proc.c                         |   7 +-
 fs/nfsd/nfs4state.c                        |  63 ++--
 fs/nfsd/nfscache.c                         |  57 +--
 fs/nfsd/nfsctl.c                           |  26 +-
 fs/nfsd/state.h                            |   7 -
 fs/nfsd/trace.h                            | 345 +++++++++++++++++
 include/linux/sunrpc/svc.h                 |   1 +
 include/linux/sunrpc/svc_rdma.h            |   6 +-
 include/linux/sunrpc/svc_xprt.h            |   6 +
 include/linux/sunrpc/svcsock.h             |   6 +-
 include/trace/events/rpcrdma.h             | 142 +++++--
 include/trace/events/sunrpc.h              | 419 +++++++++++++++++++--
 net/sunrpc/svc.c                           |  19 +-
 net/sunrpc/svc_xprt.c                      |  52 +--
 net/sunrpc/svcsock.c                       | 407 ++++++++++----------
 net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 121 ++----
 net/sunrpc/xprtrdma/svc_rdma_recvfrom.c    |  21 +-
 net/sunrpc/xprtrdma/svc_rdma_rw.c          |  92 ++---
 net/sunrpc/xprtrdma/svc_rdma_sendto.c      |  10 +-
 net/sunrpc/xprtrdma/svc_rdma_transport.c   |  55 ++-
 net/sunrpc/xprtsock.c                      |  12 +-
 22 files changed, 1321 insertions(+), 590 deletions(-)

--
Chuck Lever