Skip to content

RFC drm: introduce new method of creating debugfs files.

Wambui Karuga dri-devel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/debugfs: create debugfs files during drm_dev_register().drivers/gpu/drm/drm_debugfs.c drivers/gpu/drm/drm_drv.c include/drm/drm_debugfs.h +1 more+107 -43 replies
2/3drm/vc4: use new debugfs functions for file creation.drivers/gpu/drm/vc4/vc4_bo.c drivers/gpu/drm/vc4/vc4_debugfs.c drivers/gpu/drm/vc4/vc4_hdmi.c +2 more+16 -380 replies
3/3drm: use new debugfs functions for various files.drivers/gpu/drm/drm_atomic.c drivers/gpu/drm/drm_client.c drivers/gpu/drm/drm_framebuffer.c+15 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/3] drm: introduce new method of creating debugfs files.

Hi All,

Currently drm debugfs files are created using drm_debugfs_create_files() on request.
This series introduces new functions and infrastructure that will enable the mass creation of debugfs files during drm_dev_register(). Drivers can request for the creation of debugfs files at any time using two new
functions: drm_debugfs_add_files()/drm_debugfs_add_file(). The file requests are added to a list and tracked until drm_dev_register() when the files are created all at once.

This concept was already in use by the drm/vc4 driver and this series tries to introduce the same infrastructure in drm core. Patch 2 removes vc4's functions doing the same, and replaces it with the new drm core functions.
Patch 3 is an example of how the new functions and structs can replace the existing drm_info_list and drm_debugfs_create_files() usage.

Hoping to get some feedback or comments on the current progress of this series.

Thanks,
wambui karuga

Wambui Karuga (3):
drm/debugfs: create debugfs files during drm_dev_register(). drm/vc4: use new debugfs functions for file creation.
drm: use new debugfs functions for various files.

 drivers/gpu/drm/drm_atomic.c      | 11 +++---
 drivers/gpu/drm/drm_client.c      | 11 +++---
 drivers/gpu/drm/drm_debugfs.c     | 59 ++++++++++++++++++++++++++++---
 drivers/gpu/drm/drm_drv.c         |  2 ++
 drivers/gpu/drm/drm_framebuffer.c | 11 +++---
 drivers/gpu/drm/vc4/vc4_bo.c      |  4 +--
 drivers/gpu/drm/vc4/vc4_debugfs.c | 38 +++++---------------
 drivers/gpu/drm/vc4/vc4_hdmi.c    |  4 +--
 drivers/gpu/drm/vc4/vc4_hvs.c     |  4 +--
 drivers/gpu/drm/vc4/vc4_v3d.c     |  4 +--
 include/drm/drm_debugfs.h         | 38 ++++++++++++++++++++
 include/drm/drm_device.h          | 12 +++++++
 12 files changed, 138 insertions(+), 60 deletions(-)
Signature · 1 line
2.26.2