Skip to content

Default to cachable mappings for GEM SHMEM

Thomas Zimmermann dri-devel virtualization 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 2 repliesSuperseded
  3. v12 patches 16 repliesSuperseded

Changes in v3 from the cover letter

* fix dereferencing of an uninitialized pointer (Dan, kernel test robot)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/shmem-helper: Use cached mappings by defaultdrivers/gpu/drm/drm_gem_shmem_helper.c drivers/gpu/drm/lima/lima_gem.c drivers/gpu/drm/panfrost/panfrost_gem.c +3 more+13 -120 replies
2/2drm/shmem-helper: Removed drm_gem_shmem_create_object_cached()drivers/gpu/drm/drm_gem_shmem_helper.c drivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/udl/udl_drv.c +2 more+0 -330 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMaxime Ripard
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Default to cachable mappings for GEM SHMEM

By default, SHMEM GEM helpers map pages using writecombine. Only a few drivers require this setting. Others revert it to default mappings flags. Some could benefit from caching, but don't care.

Unify the behaviour by switching the SHMEM GEM code to use cached mappings (i.e., PAGE_KERNEL actually); just like regular shmem memory does. The 3 drivers that require write combining explicitly select it during GEM object creation.

The exception is dma-buf imported pages, which are always mapped using writecombine mode.

v3:
* fix dereferencing of an uninitialized pointer (Dan, kernel test robot)
v2:
* recreate patches on top of latest SHMEM helpers
* update lima, panfrost, v3d (Daniel, Rob)
* udl has been updated before separately.

Thomas Zimmermann (2):
drm/shmem-helper: Use cached mappings by default drm/shmem-helper: Removed drm_gem_shmem_create_object_cached()

 drivers/gpu/drm/drm_gem_shmem_helper.c  | 40 +++++--------------------
 drivers/gpu/drm/lima/lima_gem.c         |  2 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c   |  1 -
 drivers/gpu/drm/panfrost/panfrost_gem.c |  2 +-
 drivers/gpu/drm/udl/udl_drv.c           |  2 --
 drivers/gpu/drm/v3d/v3d_bo.c            |  2 +-
 drivers/gpu/drm/virtio/virtgpu_object.c |  1 -
 drivers/gpu/drm/vkms/vkms_drv.c         |  1 -
 include/drm/drm_gem_shmem_helper.h      |  7 ++---
 9 files changed, 13 insertions(+), 45 deletions(-)

--
2.29.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel