Skip to content

fs: reduce export usage of kerne_read*() calls

Luis Chamberlain kexec linux-fsdevel linux-integrity linux-security-module lkml selinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fs: unexport kernel_read_file()fs/exec.c+0 -10 replies
2/3security: add symbol namespace for reading file datadrivers/base/firmware_loader/fallback.c fs/exec.c kernel/kexec.c +2 more+10 -35 replies
3/3fs: move kernel_read*() calls to its own symbol namespacedrivers/base/firmware_loader/main.c fs/exec.c kernel/kexec_file.c +7 more+21 -31 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

While reviewing Scott Branden's submission of the new Broadcom VK driver driver upstream [0], part of which included 4 new pread varaints of the existing kernel_read*(), calls I grew shivers of the possibility of drivers using these exported symbols loosely. If we're going to grow these, it seems best to restrict the symbols to a namespace so drivers and subsystem maintainers don't use these carelessly.

This should also help with making it easier to audit future locations in the kernel such read calls happen by just looking at the imports of the namespace.

This goes compile tested with allyesconfig and allmodconfig on x86_64. 0-day should have a report on build status with other configs later of my branch [1].

[0] https://lkml.kernel.org/r/[email protected]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200513-kernel-read-sym

Luis Chamberlain (3):
fs: unexport kernel_read_file()
security: add symbol namespace for reading file data
fs: move kernel_read*() calls to its own symbol namespace

 drivers/base/firmware_loader/fallback.c | 1 +
 drivers/base/firmware_loader/main.c     | 1 +
 fs/exec.c                               | 9 +++++----
 kernel/kexec.c                          | 2 ++
 kernel/kexec_file.c                     | 2 ++
 kernel/module.c                         | 3 +++
 security/integrity/digsig.c             | 3 +++
 security/integrity/ima/ima_fs.c         | 3 +++
 security/integrity/ima/ima_main.c       | 2 ++
 security/loadpin/loadpin.c              | 2 ++
 security/security.c                     | 8 +++++---
 security/selinux/hooks.c                | 2 ++
 12 files changed, 31 insertions(+), 7 deletions(-)
Signature · 1 line
2.26.2