tests/fuzz: Review notes
Status from this message: Thanks, applied to my block tree:
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | tests/fuzz/Makefile: Do not link code using unavailable devicestests/ | +3 | 0 replies | |
| 2/6 | Makefile: List fuzz targets in 'make help'Makefile | +5 | 0 replies | |
| 3/6 | tests/fuzz: Add missing space in test descriptiontests/ | +3 | 0 replies | |
| 4/6 | tests/fuzz: Remove unuseful/unused typedefstests/ | +4 | 0 replies | |
| 5/6 | tests/fuzz: Extract pciconfig_fuzz_qos() methodtests/ | +14 | 0 replies | |
| 6/6 | tests/fuzz: Extract ioport_fuzz_qtest() methodtests/ | +9 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/6] tests/fuzz: Review notes
I took some code notes while testing Alex's toy.
Sending them as patches.
Alex, I had theses issues while building following docs/devel/fuzzing.txt:
CC nbd/server.o
nbd/server.c:1937:1: error: unused function 'glib_listautoptr_cleanup_NBDExtentArray' [-Werror,-Wunused-function] G_DEFINE_AUTOPTR_CLEANUP_FUNC(NBDExtentArray, nbd_extent_array_free);
^
/usr/include/glib-2.0/glib/gmacros.h:462:22: note: expanded from macro 'G_DEFINE_AUTOPTR_CLEANUP_FUNC'
static inline void _GLIB_AUTOPTR_LIST_FUNC_NAME(TypeName) (GList **_l) { g_list_free_full (*_l, (GDestroyNotify) func); } \
^
/usr/include/glib-2.0/glib/gmacros.h:443:48: note: expanded from macro '_GLIB_AUTOPTR_LIST_FUNC_NAME'
#define _GLIB_AUTOPTR_LIST_FUNC_NAME(TypeName) glib_listautoptr_cleanup_##TypeName
^Solved by using './configure ... --extra-cflags=-Wno-unused-function'
LINK i386-softmmu/qemu-fuzz-i386
/usr/lib64/clang/9.0.1/lib/linux/libclang_rt.asan-aarch64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition /usr/lib64/clang/9.0.1/lib/linux/libclang_rt.asan-aarch64.a(asan_interceptors.cc.o): warning: defined here
I simply ignore this warning.
Alex, could you provide few more examples (in particular about instantiating devices, or useful libfuzzer arguments)?
Also, I suppose you are using a script to generate the bug reports:
I can reproduce it in qemu 5.0 using:
cat << EOF | qemu-system ...
outl 0xcf8 ...
outl 0xcfc ...
...
EOF
Is this script available in the QEMU repository? I couldn't find it.
Regards,
Phil.
Philippe Mathieu-Daudé (6):
tests/fuzz/Makefile: Do not link code using unavailable devices
Makefile: List fuzz targets in 'make help' tests/fuzz: Add missing space in test description tests/fuzz: Remove unuseful/unused typedefs tests/fuzz: Extract pciconfig_fuzz_qos() method tests/fuzz: Extract ioport_fuzz_qtest() method
Makefile | 6 +++- tests/qtest/fuzz/i440fx_fuzz.c | 47 ++++++++++++++++++++----------- tests/qtest/fuzz/Makefile.include | 6 ++-- 3 files changed, 38 insertions(+), 21 deletions(-)
Signature · 1 line
2.21.3