Skip to content

ethtool: set_channels: add a few more checks

Jakub Kicinski netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ethtool: check if there is at least one channel for TX/RX in the corenet/ethtool/channels.c net/ethtool/ioctl.c+23 -22 replies
2/3nfp: don't check lack of RX/TX channelsdrivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c+1 -22 replies
3/3ethtool: don't call set_channels in drivers if config didn't changenet/ethtool/ioctl.c+6 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMichal KubecekSimon Horman
1/3R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/3] ethtool: set_channels: add a few more checks

There seems to be a few more things we can check in the core before we call drivers' ethtool_ops->set_channels. Adding the checks to the core simplifies the drivers. This set only includes changes to the NFP driver as an example.

There is a small risk in the first patch that someone actually purposefully accepts a strange configuration without RX or TX channels, but I couldn't find such a driver in the tree.

Jakub Kicinski (3):
ethtool: check if there is at least one channel for TX/RX in the core
nfp: don't check lack of RX/TX channels
ethtool: don't call set_channels in drivers if config didn't change

 .../ethernet/netronome/nfp/nfp_net_ethtool.c  |  3 +--
 net/ethtool/channels.c                        | 20 +++++++++++++++++--
 net/ethtool/ioctl.c                           | 11 ++++++++++
 3 files changed, 30 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.4