Skip to content

x86: Clean up percpu operations

Brian Gerst lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 21 repliesIn review
  2. v17 patches 14 repliesSuperseded

Changes in v2 from the cover letter

- Add separate patch for XADD constraint fix
- Fixed sparse truncation warning
- Add cleanup of percpu_stable_op()
- Add patch to Remove PER_CPU()

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10x86/percpu: Introduce size abstraction macrosarch/x86/include/asm/percpu.h+30 -01 reply
2/10x86/percpu: Clean up percpu_to_op()arch/x86/include/asm/percpu.h+35 -554 replies
3/10x86/percpu: Clean up percpu_from_op()arch/x86/include/asm/percpu.h+15 -350 replies
4/10x86/percpu: Clean up percpu_add_op()arch/x86/include/asm/percpu.h+22 -771 reply
5/10x86/percpu: Remove "e" constraint from XADDarch/x86/include/asm/percpu.h+1 -11 reply
6/10x86/percpu: Clean up percpu_add_return_op()arch/x86/include/asm/percpu.h+16 -351 reply
7/10x86/percpu: Clean up percpu_xchg_op()arch/x86/include/asm/percpu.h+18 -430 replies
8/10x86/percpu: Clean up percpu_cmpxchg_op()arch/x86/include/asm/percpu.h+18 -400 replies
9/10x86/percpu: Clean up percpu_stable_op()arch/x86/include/asm/percpu.h+12 -293 replies
10/10x86/percpu: Remove unused PER_CPU() macroarch/x86/include/asm/percpu.h+0 -181 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNick DesaulniersPeter Zijlstra (Intel)
SeriesR-b T-b A-b
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] x86: Clean up percpu operations

The core percpu operations already have a switch on the width of the data type, which resulted in an extra amount of dead code being generated with the x86 operations having another switch. This patch set rewrites the x86 ops to remove the switch. Additional cleanups are to use named assembly operands, and to cast variables to the width used in the assembly to make Clang happy.

Changes from v1:
- Add separate patch for XADD constraint fix
- Fixed sparse truncation warning
- Add cleanup of percpu_stable_op()
- Add patch to Remove PER_CPU()

Brian Gerst (10):
x86/percpu: Introduce size abstraction macros
x86/percpu: Clean up percpu_to_op()
x86/percpu: Clean up percpu_from_op()
x86/percpu: Clean up percpu_add_op()
x86/percpu: Remove "e" constraint from XADD
x86/percpu: Clean up percpu_add_return_op()
x86/percpu: Clean up percpu_xchg_op()
x86/percpu: Clean up percpu_cmpxchg_op()
x86/percpu: Clean up percpu_stable_op()
x86/percpu: Remove unused PER_CPU() macro

 arch/x86/include/asm/percpu.h | 510 ++++++++++++----------------------
 1 file changed, 172 insertions(+), 338 deletions(-)

base-commit: 229aaa8c059f2c908e0561453509f996f2b2d5c4

Signature · 1 line
2.25.4