auto detect REG_ILLSEQ
Get series with b4
b4 am [email protected]Versions newest first
- v3 Latest2 patches 1 replyIn review
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | t/helper: teach test-regex to report pattern errors (like REG_ILLSEQ)t/ | +66 | 1 reply | |
| 2/2 | t4210: detect REG_ILLSEQ dynamically and skip affected testst/ t/ | +59 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Junio C Hamano | Eric Sunshine |
|---|---|---|
| 1/2 | Based-on-patch-by | |
| 2/2 | Helped-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/2] auto detect REG_ILLSEQ
This is a reroll for cb/t4210-illseq-auto-detect that includes all feedback and split on two steps for easy of reviewing.
While the refactoring in test-regex.c is a little more intrusive that needed, makes the logic easier to follow and the different use cases more straightforward.
Note that there is still a leak in the use of regex_t, and had kept all original assumptions for simplicity (no explicit check on REG_ILLSEQ, or unlikely differences between BASIC/EXTENDED).
Carlo Marcelo Arenas Belón (2):
t/helper: teach test-regex to report pattern errors (like REG_ILLSEQ)
t4210: detect REG_ILLSEQ dynamically and skip affected tests
t/helper/test-regex.c | 94 ++++++++++++++++++++++++++++++------------- t/t4210-log-i18n.sh | 77 ++++++++++++++++++++++++++--------- t/test-lib.sh | 6 --- 3 files changed, 125 insertions(+), 52 deletions(-)
Signature · 1 line
2.27.0.rc0.183.gde8f92d652