fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v10 Latest5 patches 13 repliesIn review
- v95 patches 5 repliesSuperseded
- v85 patches 6 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 | 5 patches | 16 replies | Superseded | |
| v6 | 5 patches | 15 replies | Superseded |
Changes in v10 from the cover letter
- intent to address Daniel suggestions, rewrite of crypto/* code Since v8:
- addressed Laszlo review comments (reword/typos) Since v7:
- addressed Laszlo review comments
Patches in v10 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | crypto: Add tls-cipher-suites objectcrypto/ crypto/ crypto/ +2 more | +179 | 2 replies | |
| 2/5 | hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interfacedocs/ hw/ include/ | +86 | 1 reply | |
| 3/5 | softmmu/vl: Let -fw_cfg option take a 'gen_id' argumentsoftmmu/ | +21 | 1 reply | |
| 4/5 | softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 'etc/' namespacedocs/ softmmu/ | +11 | 1 reply | |
| 5/5 | crypto/tls-cipher-suites: Produce fw_cfg consumable blobcrypto/ qemu-options.hx | +29 | 2 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Laszlo Ersek | Daniel P. Berrangé |
|---|---|---|
| 1/5 | A-b | R-b |
| 2/5 | R-b | R-b |
| 3/5 | R-b | R-b |
| 4/5 | R-b | R-b |
| 5/5 | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v10 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites
Hi,
This series has 3 parts:
- First we add the tls-cipher-suites object
- We add the ability to QOM objects to produce data consumable by the fw_cfg device,
- Then we let the tls-cipher-suites object implement the FW_CFG_DATA_GENERATOR interface.
This is required by EDK2 'HTTPS Boot' feature [*] to tell the guest which TLS ciphers it can use.
Since v9:
- intent to address Daniel suggestions, rewrite of crypto/* code Since v8:
- addressed Laszlo review comments (reword/typos) Since v7:
- addressed Laszlo review comments
Since v6:
- addressed Laszlo & Daniel review comments
Since v5:
- Complete rewrite after chatting with Daniel Berrangé Since v4:
- Addressed Laszlo comments (see patch#1 description) Since v3:
- Addressed Markus' comments (do not care about heap) Since v2:
- Split of
Since v1:
- Addressed Michael and Laszlo comments.
Phil.
$ git backport-diff -u v9 Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/5:[0139] [FC] 'crypto: Add tls-cipher-suites object'
002/5:[0052] [FC] 'hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface' 003/5:[0010] [FC] 'softmmu/vl: Let -fw_cfg option take a 'gen_id' argument' 004/5:[----] [--] 'softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 'etc/' namespace' 005/5:[0018] [FC] 'crypto/tls-cipher-suites: Produce fw_cfg consumable blob'
[*]: https://github.com/tianocore/edk2/blob/master/OvmfPkg/README
v9: https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg04046.html
v8: https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg02428.html
v7: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08050.html
v6: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg05448.html
v5: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg04525.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04300.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02965.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02522.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01598.html
Philippe Mathieu-Daudé (5):
crypto: Add tls-cipher-suites object
hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface softmmu/vl: Let -fw_cfg option take a 'gen_id' argument softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 'etc/' namespace crypto/tls-cipher-suites: Produce fw_cfg consumable blob
docs/specs/fw_cfg.txt | 13 ++- include/crypto/tls-cipher-suites.h | 39 +++++++++ include/hw/nvram/fw_cfg.h | 43 ++++++++++ crypto/tls-cipher-suites.c | 126 +++++++++++++++++++++++++++++ hw/nvram/fw_cfg.c | 35 ++++++++ softmmu/vl.c | 37 ++++++--- crypto/Makefile.objs | 1 + crypto/trace-events | 5 ++ qemu-options.hx | 37 +++++++++ 9 files changed, 326 insertions(+), 10 deletions(-) create mode 100644 include/crypto/tls-cipher-suites.h create mode 100644 crypto/tls-cipher-suites.c
Signature · 1 line
2.21.3