Skip to content

PCI: Reference bridge window resources explicitly

Krzysztof Wilczynski linux-pci 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 0 repliesNew
  2. v32 patches 3 repliesApplied
  3. v23 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch0 repliesSuperseded

Changes in v4 from the cover letter

Correct variable name as per the kbuild bot feedback. Added "Acked-by" from Dominik Brodowski for the PCMCIA changes. Update cover letter wording.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2PCI: Move from using PCI_BRIDGE_RESOURCES to bridge resource definitionsdrivers/pci/quirks.c drivers/pci/setup-bus.c drivers/pcmcia/yenta_socket.c +1 more+104 -800 replies
2/2pcmcia: Use resources definitions when freeing CardBus resourcesdrivers/pcmcia/yenta_socket.c+16 -80 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchDominik Brodowski
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] PCI: Reference bridge window resources explicitly

Add definitions to allow for more explicit mapping of PCI-to-PCI (P2P) and CardBus bridge window resources.

Added for P2P:

PCI_BRIDGE_RESOURCES + 0 -> PCI_BRIDGE_IO_WINDOW PCI_BRIDGE_RESOURCES + 1 -> PCI_BRIDGE_MEM_WINDOW PCI_BRIDGE_RESOURCES + 2 -> PCI_BRIDGE_PREF_MEM_WINDOW

Added for CardBus:

PCI_BRIDGE_RESOURCES + 0 -> PCI_CB_BRIDGE_IO_0_WINDOW PCI_BRIDGE_RESOURCES + 1 -> PCI_CB_BRIDGE_IO_1_WINDOW PCI_BRIDGE_RESOURCES + 2 -> PCI_CB_BRIDGE_MEM_0_WINDOW PCI_BRIDGE_RESOURCES + 3 -> PCI_CB_BRIDGE_MEM_1_WINDOW

The old way of addressing resources using an index:

bridge->resource[PCI_BRIDGE_RESOURCES+0]

Would now be replaced with:

bridge->resource[PCI_BRIDGE_IO_WINDOW]

This series of patches builds on top of the changes proposed before:

https://lore.kernel.org/r/[email protected]
https://lore.kernel.org/r/[email protected]

Krzysztof Wilczynski (2):
PCI: Move from using PCI_BRIDGE_RESOURCES to bridge resource
definitions
pcmcia: Use resources definitions when freeing CardBus resources

---
Changes in v4:
Correct variable name as per the kbuild bot feedback. Added "Acked-by" from Dominik Brodowski for the PCMCIA changes. Update cover letter wording.

Changes in v3:
Remove the PCI quirk patch for ALI M7101 chipset as it's not needed. Remove surplus new variables added in pci_bus_size_cardbus().

Changes in v2:
Split patches based on the feedback from Bjorn allowing for the patch that correct the PCI quirk for the ALI chipset to be applied independently, if someone needs to cherry-pick it, before updating the said quirk to use definitions for bridge window resources.

Krzysztof Wilczynski (2):
PCI: Move from using PCI_BRIDGE_RESOURCES to bridge resource
definitions
pcmcia: Use resources definitions when freeing CardBus resources

 drivers/pci/quirks.c          |  34 +++++-----
 drivers/pci/setup-bus.c       | 114 ++++++++++++++++++----------------
 drivers/pcmcia/yenta_socket.c |  46 +++++++++-----
 include/linux/pci.h           |  14 ++++-
 4 files changed, 120 insertions(+), 88 deletions(-)
Signature · 1 line
2.26.2