Skip to content

media: mtk-vcodec: venc: support for MT8183

Alexandre Courbot linux-devicetree linux-media linux-mediatek lkml oe-kbuild-all 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest17 patches 10 repliesIn review
  2. v316 patches 22 repliesSuperseded
  3. v218 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches20 repliesSuperseded

Changes in v4 from the cover letter

* Link mtk_vcodec_fw.o to the mtk_vcodec_common module
* Add some documentation to structures used for firmware communication
* Remove some on-the-spot variables renamings that were distracting
* Add device tree nodes for MT8183 boards
* Carry new Acked-bys

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17media: mtk-vcodec: abstract firmware interfacedrivers/media/platform/mtk-vcodec/Makefile drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c +18 more+291 -1040 replies
2/17dt-bindings: media: mtk-vcodec: document SCP nodeDocumentation/devicetree/bindings/media/mediatek-vcodec.txt+3 -11 reply
3/17media: mtk-vcodec: add SCP firmware opsdrivers/media/platform/Kconfig drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c +2 more+65 -01 reply
4/17media: mtk-vcodec: venc: support SCP firmwaredrivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c +5 more+202 -570 replies
5/17media: mtk-vcodec: venc: handle firmware version fielddrivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c drivers/media/platform/mtk-vcodec/venc_ipi_msg.h +1 more+38 -70 replies
6/17media: mtk-vcodec: venc: specify bitrate range per-chipdrivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c+8 -10 replies
7/17media: mtk-vcodec: venc: specify supported formats per-chipdrivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c+95 -750 replies
8/17dt-bindings: media: document mediatek,mt8183-vcodec-encDocumentation/devicetree/bindings/media/mediatek-vcodec.txt+3 -20 replies
9/17arm64: dts: mt8183: add encoder nodearch/arm64/boot/dts/mediatek/mt8183-evb.dts arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi arch/arm64/boot/dts/mediatek/mt8183.dtsi+58 -04 replies
10/17media: mtk-vcodec: add support for MT8183 encoderdrivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c+23 -00 replies
11/17Revert "media: mtk-vcodec: Remove extra area allocation in an input buffer on encoding"drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c+6 -30 replies
12/17media: mtk-vcodec: venc support MIN_OUTPUT_BUFFERS controldrivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c+2 -00 replies
13/17media: mtk-vcodec: venc: set OUTPUT buffers field to V4L2_FIELD_NONEdrivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c+9 -00 replies
14/17media: mtk-vcodec: venc: use platform data for ENUM_FRAMESIZESdrivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c+10 -141 reply
15/17media: mtk-vcodec: venc: support ENUM_FRAMESIZES on OUTPUT formatsdrivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c+33 -381 reply
16/17media: mtk-vcodec: venc: set default time per framedrivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c+5 -01 reply
17/17media: mtk-vcodec: venc: fix invalid time per frame in S_PARMdrivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c+8 -41 reply

Reviews trailers per patch

16 of 17 patches have a Reviewed-by or Acked-by.

PatchTiffany LinRob Herring
1/17R-b A-b
2/17A-b A-b
3/17A-b
4/17A-b
5/17A-b
6/17A-b
7/17A-b
8/17A-b
9/17
10/17A-b
11/17A-b
12/17A-b
13/17A-b
14/17A-b
15/17A-b
16/17A-b
17/17A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/17] media: mtk-vcodec: venc: support for MT8183

Here is new respin of the MT8183 encoder support and v4l2-compliance fixes series, addressing issues raised during the v3 review (thanks in particular to Ezequiel for the feedback!). With this version I hope to complete the collection of Acked-by from respective maintainers. A few driver patches still need approval for the mtk-vcodec maintainer, and so does the patch adding the device tree node (9/17) that is new to this series.

This series has been tested and confirmed to work on both Hana (MT8173) and Krane (MT8183) Chromebooks. v4l2-compliance also passed successfully on both devices.

Changes since v3:
* Link mtk_vcodec_fw.o to the mtk_vcodec_common module
* Add some documentation to structures used for firmware communication
* Remove some on-the-spot variables renamings that were distracting
* Add device tree nodes for MT8183 boards
* Carry new Acked-bys

Changes since v2:
* Carried new Acked-bys from mtk-vcodec maintainer
* Removed 2 patches that were triggered by a bug in v4l2-compliance
* Moved DT bindings patches before the code implementing them

Changes since v1:
* Checked that no regressions against v4l2-compliance were introduced,
* Fixed 9 failing v4l2-compliance tests,
* Removed 1 cleanup patch of contested utility,
* Carried Acked-bys and Reviewed-bys from mtk-vcodec maintainer.

Alexandre Courbot (13):
dt-bindings: media: mtk-vcodec: document SCP node
media: mtk-vcodec: venc: handle firmware version field
media: mtk-vcodec: venc: specify bitrate range per-chip
media: mtk-vcodec: venc: specify supported formats per-chip
dt-bindings: media: document mediatek,mt8183-vcodec-enc
arm64: dts: mt8183: add encoder node
Revert "media: mtk-vcodec: Remove extra area allocation in an input
buffer on encoding"
media: mtk-vcodec: venc support MIN_OUTPUT_BUFFERS control
media: mtk-vcodec: venc: set OUTPUT buffers field to V4L2_FIELD_NONE
media: mtk-vcodec: venc: use platform data for ENUM_FRAMESIZES
media: mtk-vcodec: venc: support ENUM_FRAMESIZES on OUTPUT formats
media: mtk-vcodec: venc: set default time per frame
media: mtk-vcodec: venc: fix invalid time per frame in S_PARM

Yunfei Dong (4):
media: mtk-vcodec: abstract firmware interface
media: mtk-vcodec: add SCP firmware ops
media: mtk-vcodec: venc: support SCP firmware
media: mtk-vcodec: add support for MT8183 encoder

 .../bindings/media/mediatek-vcodec.txt        |   9 +-
 arch/arm64/boot/dts/mediatek/mt8183-evb.dts   |  10 +
 .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi |  12 +
 arch/arm64/boot/dts/mediatek/mt8183.dtsi      |  36 +++
 drivers/media/platform/Kconfig                |   1 +
 drivers/media/platform/mtk-vcodec/Makefile    |   6 +-
 .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c  |  53 ++--
 .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c   |   1 -
 .../platform/mtk-vcodec/mtk_vcodec_drv.h      |  40 ++-
 .../platform/mtk-vcodec/mtk_vcodec_enc.c      | 211 ++++++++--------
 .../platform/mtk-vcodec/mtk_vcodec_enc_drv.c  | 173 +++++++++----
 .../platform/mtk-vcodec/mtk_vcodec_enc_pm.c   |   2 -
 .../media/platform/mtk-vcodec/mtk_vcodec_fw.c | 228 ++++++++++++++++++
 .../media/platform/mtk-vcodec/mtk_vcodec_fw.h |  38 +++
 .../platform/mtk-vcodec/mtk_vcodec_util.c     |   1 -
 .../platform/mtk-vcodec/vdec/vdec_h264_if.c   |   1 -
 .../platform/mtk-vcodec/vdec/vdec_vp8_if.c    |   1 -
 .../platform/mtk-vcodec/vdec/vdec_vp9_if.c    |   1 -
 .../media/platform/mtk-vcodec/vdec_drv_base.h |   2 -
 .../media/platform/mtk-vcodec/vdec_drv_if.c   |   1 -
 .../media/platform/mtk-vcodec/vdec_vpu_if.c   |  12 +-
 .../media/platform/mtk-vcodec/vdec_vpu_if.h   |  11 +-
 .../platform/mtk-vcodec/venc/venc_h264_if.c   |  68 +++++-
 .../platform/mtk-vcodec/venc/venc_vp8_if.c    |  11 +-
 .../media/platform/mtk-vcodec/venc_drv_if.c   |   1 -
 .../media/platform/mtk-vcodec/venc_drv_if.h   |  13 +
 .../media/platform/mtk-vcodec/venc_ipi_msg.h  |  27 ++-
 .../media/platform/mtk-vcodec/venc_vpu_if.c   | 141 ++++++++---
 .../media/platform/mtk-vcodec/venc_vpu_if.h   |   8 +-
 29 files changed, 836 insertions(+), 283 deletions(-)
 create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_fw.c
 create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_fw.h

--
2.28.0.297.g1956fa8f8d-goog

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek