Skip to content

net: atlantic: QoS implementation

Igor Russkikh netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 5 repliesIn review
  2. v112 patches 8 repliesSuperseded

Changes in v2 from the cover letter

* accommodated review comments (-Wmissing-prototypes and -Wunused-but-set-variable findings);
* added user notification in case of conflicting multi-TC<->PTP configuration;
* added automatic PTP disabling, if a conflicting configuration is detected;
* removed module param, which was used for PTP disabling in v1;

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12net: atlantic: changes for multi-TC supportdrivers/net/ethernet/aquantia/atlantic/aq_hw.h drivers/net/ethernet/aquantia/atlantic/aq_macsec.c drivers/net/ethernet/aquantia/atlantic/aq_nic.c +9 more+105 -723 replies
2/12net: atlantic: move PTP TC initialization to a separate functiondrivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c+19 -120 replies
3/12net: atlantic: changes for multi-TC supportdrivers/net/ethernet/aquantia/atlantic/aq_hw.h drivers/net/ethernet/aquantia/atlantic/aq_nic.c drivers/net/ethernet/aquantia/atlantic/aq_nic.h +3 more+75 -550 replies
4/12net: atlantic: QoS implementation: multi-TC supportdrivers/net/ethernet/aquantia/atlantic/aq_filters.c drivers/net/ethernet/aquantia/atlantic/aq_hw.h drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.c +12 more+293 -1140 replies
5/12net: atlantic: per-TC queue statisticsdrivers/net/ethernet/aquantia/atlantic/aq_ethtool.c drivers/net/ethernet/aquantia/atlantic/aq_nic.c drivers/net/ethernet/aquantia/atlantic/aq_vec.c +1 more+59 -410 replies
6/12net: atlantic: make TCVEC2RING accept nic_cfgdrivers/net/ethernet/aquantia/atlantic/aq_ethtool.c drivers/net/ethernet/aquantia/atlantic/aq_nic.c drivers/net/ethernet/aquantia/atlantic/aq_nic.h +1 more+15 -120 replies
7/12net: atlantic: QoS implementation: max_ratedrivers/net/ethernet/aquantia/atlantic/aq_hw.h drivers/net/ethernet/aquantia/atlantic/aq_main.c drivers/net/ethernet/aquantia/atlantic/aq_nic.c +7 more+235 -120 replies
8/12net: atlantic: automatically downgrade the number of queues if necessarydrivers/net/ethernet/aquantia/atlantic/aq_ethtool.c drivers/net/ethernet/aquantia/atlantic/aq_main.c drivers/net/ethernet/aquantia/atlantic/aq_nic.c +1 more+63 -360 replies
9/12net: atlantic: always use random TC-queue mapping for TX on A2.drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2.c drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_llh.c drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2_llh.h +1 more+72 -110 replies
10/12net: atlantic: change the order of arguments for TC weight/credit settersdrivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.c +3 more+35 -350 replies
11/12net: atlantic: QoS implementation: min_ratedrivers/net/ethernet/aquantia/atlantic/aq_hw.h drivers/net/ethernet/aquantia/atlantic/aq_main.c drivers/net/ethernet/aquantia/atlantic/aq_nic.c +7 more+286 -540 replies
12/12net: atlantic: proper rss_ctrl1 (54c0) initializationdrivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.h drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0_internal.h +2 more+21 -80 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJakub Kicinski
SeriesA-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net-next 00/12] net: atlantic: QoS implementation

This patch series adds support for mqprio rate limiters and multi-TC:
* max_rate is supported on both A1 and A2;
* min_rate is supported on A2 only;

This is a joint work of Mark and Dmitry.

To implement this feature, a couple of rearrangements and code improvements were done, in areas of TC/ring management, allocation control, etc.

One of the problems we faced is conflicting ptp functionality, which consumes a whole traffic class due to hardware limitations. Patches below have a more detailed description on how PTP and multi-TC co-exist right now.

v2:
* accommodated review comments (-Wmissing-prototypes and -Wunused-but-set-variable findings);
* added user notification in case of conflicting multi-TC<->PTP configuration;
* added automatic PTP disabling, if a conflicting configuration is detected;
* removed module param, which was used for PTP disabling in v1;

v1: https://patchwork.ozlabs.org/cover/1294380/

Dmitry Bezrukov (4):
net: atlantic: changes for multi-TC support
net: atlantic: move PTP TC initialization to a separate function
net: atlantic: changes for multi-TC support
net: atlantic: QoS implementation: multi-TC support

Mark Starovoytov (8):
net: atlantic: per-TC queue statistics
net: atlantic: make TCVEC2RING accept nic_cfg
net: atlantic: QoS implementation: max_rate
net: atlantic: automatically downgrade the number of queues if
necessary
net: atlantic: always use random TC-queue mapping for TX on A2.
net: atlantic: change the order of arguments for TC weight/credit
setters
net: atlantic: QoS implementation: min_rate
net: atlantic: proper rss_ctrl1 (54c0) initialization

 .../ethernet/aquantia/atlantic/aq_ethtool.c   |  74 +++--
 .../ethernet/aquantia/atlantic/aq_filters.c   |  11 +-
 .../net/ethernet/aquantia/atlantic/aq_hw.h    |  20 +-
 .../ethernet/aquantia/atlantic/aq_hw_utils.c  |  26 ++
 .../ethernet/aquantia/atlantic/aq_hw_utils.h  |   2 +
 .../ethernet/aquantia/atlantic/aq_macsec.c    |   2 +-
 .../net/ethernet/aquantia/atlantic/aq_main.c  |  72 ++++-
 .../net/ethernet/aquantia/atlantic/aq_nic.c   | 265 +++++++++++----
 .../net/ethernet/aquantia/atlantic/aq_nic.h   |  27 +-
 .../ethernet/aquantia/atlantic/aq_pci_func.c  |   3 +
 .../net/ethernet/aquantia/atlantic/aq_ptp.c   |  27 +-
 .../net/ethernet/aquantia/atlantic/aq_ring.c  |  19 +-
 .../net/ethernet/aquantia/atlantic/aq_vec.c   |  72 +++--
 .../net/ethernet/aquantia/atlantic/aq_vec.h   |   8 +-
 .../aquantia/atlantic/hw_atl/hw_atl_a0.c      |  10 +-
 .../aquantia/atlantic/hw_atl/hw_atl_b0.c      | 255 ++++++++++-----
 .../aquantia/atlantic/hw_atl/hw_atl_b0.h      |   2 +
 .../atlantic/hw_atl/hw_atl_b0_internal.h      |   6 +-
 .../aquantia/atlantic/hw_atl/hw_atl_llh.c     |  65 +++-
 .../aquantia/atlantic/hw_atl/hw_atl_llh.h     |  32 +-
 .../atlantic/hw_atl/hw_atl_llh_internal.h     | 101 +++++-
 .../aquantia/atlantic/hw_atl2/hw_atl2.c       | 301 +++++++++++++-----
 .../atlantic/hw_atl2/hw_atl2_internal.h       |  12 +-
 .../aquantia/atlantic/hw_atl2/hw_atl2_llh.c   |  36 ++-
 .../aquantia/atlantic/hw_atl2/hw_atl2_llh.h   |  19 +-
 .../atlantic/hw_atl2/hw_atl2_llh_internal.h   | 111 +++++--
 26 files changed, 1197 insertions(+), 381 deletions(-)
Signature · 1 line
2.25.1