HMP: qom-get and set
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | hmp: Implement qom-get HMP commandhmp-commands.hx include/ qom/ +1 more | +34 | 3 replies | |
| 2/2 | hmp: Simplify qom_setqom/ | +5 | 7 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Markus Armbruster |
|---|---|---|
| 1/2 | R-b | R-b |
| 2/2 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] HMP: qom-get and set
From: "Dr. David Alan Gilbert" <[email protected]>
HMP has had a qom-set for a long time, but not a matching qom-get; various attempts have been made to add one over the last 5 years. Here's another go.
It's got simpler due to a suggestion by Markus to take the output from qmp's qom-get. While we're here, rework hmp's qom-set to be a wrapper around the qmp equivalent, which simplifies it a bit.
In one post people didn't particularly like the use of JSON, but in the intervening 4 years no one has implemented anything to avoid it, and the output is trivially readable for non-structures and still pretty readable for (the very rare) structures.
Dave
Dr. David Alan Gilbert (2):
hmp: Implement qom-get HMP command
hmp: Simplify qom_set
hmp-commands.hx | 14 ++++++++++++++ include/monitor/hmp.h | 1 + qom/qom-hmp-cmds.c | 34 +++++++++++++++++++++++----------- tests/qtest/test-hmp.c | 1 + 4 files changed, 39 insertions(+), 11 deletions(-)
Signature · 1 line
2.26.2