Skip to content

HMP: qom-get and set

Dr. David Alan Gilbert (git) qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hmp: Implement qom-get HMP commandhmp-commands.hx include/monitor/hmp.h qom/qom-hmp-cmds.c +1 more+34 -03 replies
2/2hmp: Simplify qom_setqom/qom-hmp-cmds.c+5 -117 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéMarkus Armbruster
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] HMP: qom-get and set

From: "Dr. David Alan Gilbert" <[email protected]>

HMP has had a qom-set for a long time, but not a matching qom-get; various attempts have been made to add one over the last 5 years. Here's another go.

It's got simpler due to a suggestion by Markus to take the output from qmp's qom-get. While we're here, rework hmp's qom-set to be a wrapper around the qmp equivalent, which simplifies it a bit.

In one post people didn't particularly like the use of JSON, but in the intervening 4 years no one has implemented anything to avoid it, and the output is trivially readable for non-structures and still pretty readable for (the very rare) structures.

Dave

Dr. David Alan Gilbert (2):
hmp: Implement qom-get HMP command
hmp: Simplify qom_set

 hmp-commands.hx        | 14 ++++++++++++++
 include/monitor/hmp.h  |  1 +
 qom/qom-hmp-cmds.c     | 34 +++++++++++++++++++++++-----------
 tests/qtest/test-hmp.c |  1 +
 4 files changed, 39 insertions(+), 11 deletions(-)
Signature · 1 line
2.26.2