Fix breakage from adding MSR_IA32_UMWAIT_CONTROL
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | kvm: cosmetic: remove wrong braces in kvm_init_msr_list switcharch/ | +1 | 1 reply | |
| 2/2 | kvm/x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionallyarch/ | +4 | 14 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Vitaly Kuznetsov |
|---|---|
| 1/2 | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] Fix breakage from adding MSR_IA32_UMWAIT_CONTROL
Currently code in kvm_get_supported_msrs always returns this msr as supported by KVM, however it is not supported at all on AMD and it is only supported on few select Intel systems.
This happened to work in native virtualization case, because KVM's code also tries to read these msrs, and on an exception drops them from the supported msr list.
However when running nested, and outer hypervisor set to ignore unknown msrs, the read from this msr doesn't get an excption, and thus KVM thinks that this msr should be on supported msr list.
I don't think we should rely on exception to check if a feature is supported since that msr can be even in theory assigned to something else on AMD for example.
Also I included a cosmetic fix for an issue I found in the same function.
Best regards,
Maxim Levitsky
Maxim Levitsky (2):
kvm: cosmetic: remove wrong braces in kvm_init_msr_list switch kvm/x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionally
arch/x86/kvm/x86.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
Signature · 1 line
2.26.2