l2tp locking and ordering fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest22 patches 1 replyIn review
- v122 patches 0 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/22 | net: l2tp: export debug flags to UAPIinclude/ net/ | +16 | 0 replies | |
| 2/22 | net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_*Documentation/ include/ | +10 | 0 replies | |
| 3/22 | net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_*net/ | +27 | 0 replies | |
| 4/22 | New kernel function to get IP overhead on a socket.include/ net/ | +49 | 0 replies | |
| 5/22 | L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.net/ | +51 | 0 replies | |
| 6/22 | l2tp: remove useless duplicate session detection in l2tp_netlinknet/ | +0 | 0 replies | |
| 7/22 | l2tp: remove l2tp_session_find()net/ net/ | +1 | 0 replies | |
| 8/22 | l2tp: define parameters of l2tp_session_get*() as "const"net/ net/ | +7 | 0 replies | |
| 9/22 | l2tp: define parameters of l2tp_tunnel_find*() as "const"net/ net/ | +4 | 0 replies | |
| 10/22 | l2tp: initialise session's refcount before making it reachablenet/ | +2 | 0 replies | |
| 11/22 | l2tp: hold tunnel while looking up sessions in l2tp_netlinknet/ net/ net/ | +38 | 0 replies | |
| 12/22 | l2tp: hold tunnel while processing genl delete commandnet/ | +4 | 0 replies | |
| 13/22 | l2tp: hold tunnel while handling genl tunnel updatesnet/ | +4 | 0 replies | |
| 14/22 | l2tp: hold tunnel while handling genl TUNNEL_GET commandsnet/ | +15 | 0 replies | |
| 15/22 | l2tp: hold tunnel used while creating sessions with netlinknet/ | +12 | 0 replies | |
| 16/22 | l2tp: prevent creation of sessions on terminated tunnelsnet/ net/ | +32 | 0 replies | |
| 17/22 | l2tp: pass tunnel pointer to ->session_create()net/ net/ net/ +1 more | +17 | 0 replies | |
| 18/22 | l2tp: fix l2tp_eth module loadingnet/ | +2 | 0 replies | |
| 19/22 | l2tp: don't register sessions in l2tp_session_create()net/ net/ net/ +1 more | +36 | 0 replies | |
| 20/22 | l2tp: initialise l2tp_eth sessions before registering themnet/ | +76 | 0 replies | |
| 21/22 | l2tp: protect sock pointer of struct pppol2tp_session with RCUnet/ | +101 | 0 replies | |
| 22/22 | l2tp: initialise PPP sessions before registering themnet/ | +38 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 00/22] l2tp locking and ordering fixes
Hi Greg.
*Now with better spelling of "upstream".*
This is for 4.9.
This is a follow-up to "fix l2tp use-after-free in pppol2tp_sendmsg" for 4.14. Pulling on the thread pulled in many other earlier locking fixes in between 4.9 and 4.14.
I've done some minor rework on a few of these to avoid pulling in refcount as a replacement for atomic which would have meant 10+ more patches (I still had compilation errors at 10).
Some minor other patch commutation was needed and where it wasn't completely trivial, I've added a note to the commit messages.
The series does include a few non-fixes, but they look safe and mean that the fixes (and other backports) apply more cleanly.
Regards,
Giuliano.
Asbjørn Sloth Tønnesen (3):
net: l2tp: export debug flags to UAPI
net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_*
net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_*
Guillaume Nault (17):
l2tp: remove useless duplicate session detection in l2tp_netlink
l2tp: remove l2tp_session_find()
l2tp: define parameters of l2tp_session_get*() as "const"
l2tp: define parameters of l2tp_tunnel_find*() as "const"
l2tp: initialise session's refcount before making it reachable
l2tp: hold tunnel while looking up sessions in l2tp_netlink
l2tp: hold tunnel while processing genl delete command
l2tp: hold tunnel while handling genl tunnel updates
l2tp: hold tunnel while handling genl TUNNEL_GET commands
l2tp: hold tunnel used while creating sessions with netlink
l2tp: prevent creation of sessions on terminated tunnels
l2tp: pass tunnel pointer to ->session_create()
l2tp: fix l2tp_eth module loading
l2tp: don't register sessions in l2tp_session_create()
l2tp: initialise l2tp_eth sessions before registering them
l2tp: protect sock pointer of struct pppol2tp_session with RCU
l2tp: initialise PPP sessions before registering them
R. Parameswaran (2):
New kernel function to get IP overhead on a socket. L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.
Documentation/networking/l2tp.txt | 8 +- include/linux/net.h | 3 + include/uapi/linux/if_pppol2tp.h | 13 +- include/uapi/linux/l2tp.h | 17 +- net/l2tp/l2tp_core.c | 174 ++++++----------- net/l2tp/l2tp_core.h | 46 +++-- net/l2tp/l2tp_eth.c | 214 +++++++++++++-------- net/l2tp/l2tp_netlink.c | 79 ++++---- net/l2tp/l2tp_ppp.c | 309 ++++++++++++++++++------------ net/socket.c | 46 +++++ 10 files changed, 516 insertions(+), 393 deletions(-)
Signature · 1 line
2.27.0.rc0.183.gde8f92d652-goog