Skip to content

MHI patches for v5.8

[email protected] linux-arm-msm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14bus: mhi: core: Refactor mhi queue APIsdrivers/bus/mhi/core/internal.h drivers/bus/mhi/core/main.c+47 -630 replies
2/14bus: mhi: core: Cache intmod from mhi event to mhi channeldrivers/bus/mhi/core/init.c+4 -00 replies
3/14bus: mhi: core: Add range check for channel id received in event ringdrivers/bus/mhi/core/main.c+29 -110 replies
4/14bus: mhi: core: Read transfer length from an event properlydrivers/bus/mhi/core/main.c+7 -20 replies
5/14bus: mhi: core: Handle firmware load using state workerdrivers/bus/mhi/core/boot.c drivers/bus/mhi/core/init.c drivers/bus/mhi/core/internal.h +2 more+5 -230 replies
6/14bus: mhi: core: Return appropriate error codes for AMSS load failuredrivers/bus/mhi/core/boot.c+12 -110 replies
7/14bus: mhi: core: Improve debug logs for loading firmwaredrivers/bus/mhi/core/boot.c+18 -30 replies
8/14bus: mhi: core: Ensure non-zero session or sequence ID values are useddrivers/bus/mhi/core/boot.c drivers/bus/mhi/core/internal.h+8 -80 replies
9/14bus: mhi: core: Remove the system error worker threaddrivers/bus/mhi/core/init.c drivers/bus/mhi/core/internal.h drivers/bus/mhi/core/main.c +2 more+20 -250 replies
10/14bus: mhi: core: Handle disable transitions in state workerdrivers/bus/mhi/core/init.c drivers/bus/mhi/core/internal.h drivers/bus/mhi/core/pm.c+12 -10 replies
11/14bus: mhi: core: Skip handling BHI irq if MHI reg access is not alloweddrivers/bus/mhi/core/main.c+14 -70 replies
12/14bus: mhi: core: Do not process SYS_ERROR if RDDM is supporteddrivers/bus/mhi/core/main.c+8 -30 replies
13/14bus: mhi: core: Handle write lock properly in mhi_pm_m0_transitiondrivers/bus/mhi/core/pm.c+7 -30 replies
14/14bus: mhi: core: Handle syserr during power_updrivers/bus/mhi/core/pm.c+27 -00 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchJeffrey HugoManivannan SadhasivamHemant Kumar
1/14R-b R-b
2/14R-b R-b
3/14R-b R-b
4/14R-b R-b
5/14R-b R-b
6/14R-b R-b
7/14R-b R-b
8/14R-b R-b
9/14R-b R-b
10/14R-b R-b
11/14R-b R-b
12/14R-b R-b
13/14R-b
14/14R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/14] MHI patches for v5.8

From: Manivannan Sadhasivam <[email protected]>

Hi Greg,

Here is the set of MHI patches for v5.8. Most of the patches are cleanup and refactoring ones. All of them are reviewed by myself and Jeff and also verified on x86 and ARM64 architectures for functionality.

Here is the short summary:
-------------------------------------------------------------

- The firmware download was handled by a worker thread which gets scheduled when the device powers up. But this thread waits until the device gets into PBL state (notified using PM state worker). Sometimes, there might be delay for the device to enter PBL state and due to that the firmware worker thread will timeout. So in order to handle this situation effectively, the firmware load is now directly called by PM state worker instead of scheduling the thread.

- Return proper error codes incase of error while loading the AMSS firmware through BHIE protocol

- The MHI register space of the device accepts only non-zero values for the sequence identifier. But there is a possibility that the host might write zero (due to the use of prandom_u32() API). Hence, a macro is introduced which provides non-zero sequence identifiers and used them in all places.

- Moved all common TRE generation code to mhi_gen_tre() function

- The MHI host reads channel ID from the event ring element of the client device. This ID can be of any value between 0 to 255 but the host may not support all those IDs. So reject the event ring elements whose channel IDs are not within the limits of the controller.

- Limit the transfer length read from the client device. This value should be within the size of the MHI host buffer but there are chances this can be larger.

- Remove the system worker thread for processing the SYS_ERR condition and instead call the function directly from EE worker. This is done to avoid any possible race while MHI shutting down.

- Handle MHI power off in the state worker thread as like MISSION_MODE. This helps in preventing a possible race condition where a power off is issued by the controller while processing mission mode.

- Skip the handling of BHI interrupt when the register access is not allowed due to the device in wrong PM state.

- The write_lock of 'mhi_chan->lock' should only protect 'db_mode'. Hence, use it properly in places where it is protecting other unwanted regions.

- Reset the client device if it is in SYS_ERR state during power up.

-------------------------------------------------------------

Please consider merging!

Thanks,
Mani

Bhaumik Bhatt (4):
bus: mhi: core: Handle firmware load using state worker
bus: mhi: core: Return appropriate error codes for AMSS load failure
bus: mhi: core: Improve debug logs for loading firmware
bus: mhi: core: Ensure non-zero session or sequence ID values are used

Hemant Kumar (9):
bus: mhi: core: Refactor mhi queue APIs
bus: mhi: core: Cache intmod from mhi event to mhi channel
bus: mhi: core: Add range check for channel id received in event ring
bus: mhi: core: Read transfer length from an event properly
bus: mhi: core: Remove the system error worker thread
bus: mhi: core: Handle disable transitions in state worker
bus: mhi: core: Skip handling BHI irq if MHI reg access is not allowed
bus: mhi: core: Do not process SYS_ERROR if RDDM is supported
bus: mhi: core: Handle write lock properly in mhi_pm_m0_transition

Jeffrey Hugo (1):
bus: mhi: core: Handle syserr during power_up

 drivers/bus/mhi/core/boot.c     |  75 ++++++------
 drivers/bus/mhi/core/init.c     |   8 +-
 drivers/bus/mhi/core/internal.h |   9 +-
 drivers/bus/mhi/core/main.c     | 194 ++++++++++++++++++--------------
 drivers/bus/mhi/core/pm.c       |  86 +++++++++-----
 include/linux/mhi.h             |   4 -
 6 files changed, 217 insertions(+), 159 deletions(-)
Signature · 1 line
2.26.GIT